Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not compile with recent versions of rustc. #72

Closed
sebcrozet opened this issue Apr 11, 2015 · 3 comments · Fixed by #76
Closed

Does not compile with recent versions of rustc. #72

sebcrozet opened this issue Apr 11, 2015 · 3 comments · Fixed by #76

Comments

@sebcrozet
Copy link
Member

ncollide currently fails to compile with recent versions of rustc. The main reason is the removal of #![old_impl_check]. This makes the use of associated types mandatory at some places.

While I started some work on nalgebra and ncollide to fix this, I ran into an ICE − rust-lang/rust#24179. Also, rust-lang/rust#23595 prevents us from fixing ncollide without using associated types on nalgebra.

I have the feeling there is no other solutions than waiting for the compiler bug to be fixed.
@sebcrozet sebcrozet mentioned this issue Apr 11, 2015
Closed
@sebcrozet sebcrozet mentioned this issue May 1, 2015
Open
@sebcrozet sebcrozet mentioned this issue May 8, 2015
Closed
@wackywendell
Copy link
Contributor

Is there any change with this? The two rust bugs look thorny, and its really unfortunate that even with Rust 1.0 out, this still isn't working.

@sebcrozet
Copy link
Member Author

Yes, I believe I am almost done fixing everything. I worked around those bugs at a price of bad syntax at some places (e.g. things like <P::Vect as Vect>::Scalar to identify the scalar type associated to a point P where I think that bug-free associated types could allow me to write P::Scalar directly). Hopefully I will manage to land all those fixes at the end of the week!

sebcrozet added a commit that referenced this issue May 25, 2015
@sebcrozet
Update to rust 1.0 stable.
fde8a1d 
Fix #74
Fix #72
Fix #71
Closes 75
@sebcrozet sebcrozet mentioned this issue May 25, 2015
Merged
@wackywendell
Copy link
Contributor

HURRAY!!!

sebcrozet added a commit that referenced this issue Mar 2, 2020
@sebcrozet
Merge pull request #72 from arturoc/fix-alpha
d9fdb64 
fixes compiling on alpha 1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to rust 1.0 stable. dimforge/ncollide
2 participants
@wackywendell @sebcrozet