Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build for Rust 1.0 #80

Closed
wants to merge 1 commit into from
Closed

Conversation

bombless
Copy link

I think what they do in nalgebra is kinda weird because we already have associated types, but anyway this fix the build for stable Rust.

@sebcrozet
Copy link
Member

Thanks, but, what version of rustc are you using exactly ? I'm currently running rust stable 1.0 (rustc 1.0.0 (a59de37e9 2015-05-13) (built 2015-05-14) and ncollide compiles without this patch.

nalgebra does some weird things with associated types (and sometimes does not use them) because they are not yet completely supported by the compiler: I get ICEs when I try to use them.

@bombless
Copy link
Author

I don't know, but maybe you should try cargo clean && cargo build, see #78

I don't have strong opinion on this, I just saw people talking about not able to build it on IRC and come to see what I can do.

I use rustc compiled from master branch pulled one day ago by the way.

@bombless
Copy link
Author

I see, maybe the break come from nalgebra.
Then we can designate the version of nalgebra in Cargo.toml, if it do sane vesioning.

EDIT: typo

@bombless bombless closed this Jun 13, 2015
@sebcrozet
Copy link
Member

I don't recommend people to use the master branch of the compiler or even the nightlies. I believe the common approach now is to stay with the latest stable releases.

@bombless
Copy link
Author

btw, if you are using low version of nalgebra, you may need cargo update to reproduce the problem, see https://crates.io/crates/nalgebra

@bombless
Copy link
Author

tl;dr: check if you are using nalgebra 0.2.17

@bombless
Copy link
Author

@sebcrozet I'm very sorry that I didn't check it carefully.
Already filed an issue for it, rust-lang/rust#26279

sebcrozet added a commit that referenced this pull request Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants