Conversation
More info at facebook/docusaurus#9698
deps remark-math and rehype-katex updated
|
(not really related to this PR, but) on my linux, the |
…z/rapier.rs into docusaurus_3_cross_platform_inject
| build: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Run injection script locally | ||
| run: find docs/user_guides/templates/ -type f -print0 | OUTPUT_FOLDER=docs/user_guides/templates_injected xargs -0 ./inject_code_in_user_guides.sh | ||
| - name: User guides generation | ||
| run: ./generate_user_guides.sh | ||
| - name: yarn install | ||
| run: corepack enable && yarn | ||
| - name: yarn build | ||
| run: PUBLISH_MODE=1 yarn build |
There was a problem hiding this comment.
yarn build tested on CI is great, it currently outputs some warning concerning links, which might be related to #41
A good follow up Pull Request would be to eliminate these warnings. From my testing these warnings don´t indicate regressions.
There was a problem hiding this comment.
changes have been made to this script to make it more cross platform friendly. I tested on mac, windows, linux.
| if [ gsed -v ]; then | ||
| gsed=gsed | ||
| else | ||
| # Hopefully installed sed is the gnu one. | ||
| # note: aliases work poorly with xargs. | ||
| gsed=sed | ||
| fi |
There was a problem hiding this comment.
using gsed is not trivial on linux actually, so this "hack" allows for better cross platform tooling.
sebcrozet
left a comment
sebcrozet
left a comment
There was a problem hiding this comment.
Looking fantastic, thank you!
2 participants
Builds on #110