fix character controller is_grounded #711
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.1
has been kept since the creation of the character controller.Some numbers
offset is
CharacterLength::Relative(0.01)
, then the height of theCharacterController
in the exampple is0.3
, resulting in an exxaggerated offset (for aabb computation) of0.0033
. The nudge factor being0.0001
shouldn´t impact that, but we're still in small numbers game. I think overshooting a bit won´t hurt much, especially if it fixesis_grounded
reliability.TODO?
I think I can make a test about ground prediction (make a character walking on a trimesh for some time, verify it's always grounded), but I fear this test might not always catch such bug.
Alternatives
We can consider exposing this offset multiplier, or the whole AABB used.