Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making isOpen = false more accurate after closing a modal #1006

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

patri-badger
Copy link

I had an issue in the project I'm working on. We closed the modal and a backend process was so fast that when we tried to open again the modal it opened it and closed it immediately (invisible to us) because the setTimeout in close finished after we opened the new modal. This provoked our app inaccesible in the places the modal was shown. Typing in console isOpen it said true.

We were checking before opening the modal isOpen but it had false and we tried to open a new modal. With this change isOpen will be false when it has really close the modal. I hope you like this solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant