Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): change types of children & gallery options according to docs #1982

Merged
merged 1 commit into from
Oct 25, 2022
Merged

fix(types): change types of children & gallery options according to docs #1982

merged 1 commit into from
Oct 25, 2022

Conversation

Schleuse
Copy link

According to the docs the children and gallery options should also accept NodeList, HTMLElement HTMLElement[] besides a CSS-Selector. The current types don't reflect that, as they require you to pass a CSS-Selector as a string.

image

This PR adds a new type ElementProvider which encompasses those types and gets used in the types of the children & gallery options.

@dimsemenov dimsemenov merged commit 1530ea7 into dimsemenov:master Oct 25, 2022
@dimsemenov
Copy link
Owner

Thanks!

@Schleuse
Copy link
Author

Schleuse commented Oct 25, 2022 •
edited
Loading

@dimsemenov

I'm participating in Hacktoberfest. Do you mind adding the hacktoberfest-accepted label to this PR to that it's getting considered as valid PR?

@dimsemenov
Copy link
Owner

sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Schleuse @dimsemenov