Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make dataSource param optional in loadAndOpen #2069

Merged

Conversation

BeeMargarida
Copy link
Contributor

The parameter dataSource is set as required, however in the docs it's mentioned has optional.

It doesn't make sense to be required since the dataSource is not used in loadAndOpen, it's just passed to the preload method, which has dataSource as optional.

Mentioned in this issue - #2026.

@dimsemenov dimsemenov merged commit f748565 into dimsemenov:master Sep 29, 2023
@dimsemenov
Copy link
Owner

Thank you, I'll update the documentation as well, as it seems a bit confusing right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants