Correct 404 markdown links #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's how most links in the documentation are structured, are you deploying the docs in some custom subfolder? Or are you having 404 issues at https://photoswipe.com/ too? |
|
Hm, so interestingly the currently live code works on https://photoswipe.com/methods/ but not on https://github.com/dimsemenov/PhotoSwipe/blob/master/docs/methods.md (other pages links work fine, and I removed the preceding |
|
Ah, I see. I only support docs at https://photoswipe.com/getting-started/ as it includes interactive examples But it wouldn't hurt, thanks! nvm: had to revert |
dimsemenov
added a commit
that referenced
this pull request
Dec 4, 2023
This reverts commit ac7eaf6.
dimsemenov
added a commit
that referenced
this pull request
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These links in the docs were setup incorrectly leading to a 404. This PR corrects the links (removes the preceding
/)