feat: parsing let statements #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we don't have our package published / setup to publish properly, we can't pull a package from the github domain.
Created ast package which contains base, statement, expression node interfaces. Also created parser package which imports the ast, lexer, and token packages, contains token functions, statement functions, peek functions, has an error function, and began the ParseProgram() function. Created parser_test.go package as well.
This was
linked to
issues
Apr 3, 2024
4 tasks
dineshUmasankar
changed the title
dineshUmasankar
changed the title
dineshUmasankar
approved these changes
Apr 7, 2024
There was a problem hiding this comment.
From here on out, I would appreciate some inline documentation for every method and type that is defined and a package-level comment to describe the intent / purpose of the package. @katherinerbanis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created the ast.go package which contains the base node, statement node, and expression node interfaces as well as struct and tokenLiteral().
Also created the parser.go and parser_test.go. Parser imports the ast.go, lexer.go, and token.go packages, contains a struct, token functions, statement functions, error functions, and began the ParseProgram function.
Closes #14.