feat: add command and args

dineshdb · Apr 24, 2024 · bf4ccb0 · bf4ccb0
1 parent fc27d70
commit bf4ccb0
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 13 deletions.
diff --git a/.github/workflows/lint-test.yaml b/.github/workflows/lint-test.yaml
@@ -26,26 +26,25 @@ jobs:
  steps:
  # This step checks out a copy of your repository.
  - name: Checkout Milvus Helm
- uses: actions/checkout@v2
+ uses: actions/checkout@v4
  with:
  fetch-depth: 0
 
  - name: Set up Helm
- uses: azure/setup-helm@v1
+ uses: azure/setup-helm@v4.2.0
  with:
  version: v3.4.0
 
  - name: Add dependency chart repos
  run: |
- helm repo add kafkaesque https://helm.kafkaesque.io
  helm repo add bitnami https://charts.bitnami.com/bitnami
 
- - uses: actions/setup-python@v2
+ - uses: actions/setup-python@v5
  with:
- python-version: 3.7
+ python-version: "3.10"
 
  - name: Set up chart-testing
- uses: helm/chart-testing-action@v2.1.0
+ uses: helm/chart-testing-action@v2.6.0
 
  - name: Run chart-testing (list-changed)
  id: list-changed
@@ -60,7 +59,7 @@ jobs:
  run: ct lint --config ct.yaml
 
  - name: Create KinD cluster
- uses: helm/kind-action@v1.2.0
+ uses: helm/kind-action@v1
  if: steps.list-changed.outputs.changed == 'true'
 
  - name: Run chart-testing (install)

diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -14,7 +14,7 @@ jobs:
  runs-on: ubuntu-latest
  steps:
  - name: Checkout
- uses: actions/checkout@v2
+ uses: actions/checkout@v4
  with:
  fetch-depth: 0
 
@@ -23,12 +23,11 @@ jobs:
  git config user.name "$GITHUB_ACTOR"
  git config user.email "$GITHUB_ACTOR@users.noreply.github.com"
 
- - name: Install Helm
- uses: azure/setup-helm@v1
+ uses: azure/setup-helm@v4.2.0
  with:
  version: v3.8.1
 
  - name: Run chart-releaser
- uses: helm/chart-releaser-action@v1.4.0
+ uses: helm/chart-releaser-action@v1.6.0
  env:
- CR_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
+ CR_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
diff --git a/charts/assets/Chart.yaml b/charts/assets/Chart.yaml
@@ -15,7 +15,7 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.6.2
+version: 0.7.0
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to

diff --git a/charts/assets/templates/deployment.yaml b/charts/assets/templates/deployment.yaml
@@ -33,6 +33,12 @@ spec:
  {{- toYaml .Values.securityContext | nindent 12 }}
  image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
  imagePullPolicy: {{ .Values.image.pullPolicy }}
+ {{- if .Values.command }}
+ command: {{ .Values.command }}
+ {{- end }}
+ {{- if .Values.args }}
+ args: {{ .Values.args }}
+ {{- end }}
  ports:
  - name: http
  containerPort: {{ .Values.service.containerPort }}

diff --git a/charts/assets/values.yaml b/charts/assets/values.yaml
@@ -10,6 +10,9 @@ image:
  # Overrides the image tag whose default is the chart appVersion.
  tag: ""
 
+command: []
+args: []
+
 imagePullSecrets: []
 nameOverride: ""
 fullnameOverride: ""