[bug] User daily limit

[miraserver]

When creating and editing a user, the daily quota is always a required field. It's not possible to set this parameter to infinity, meaning no limit.

[github-actions]

Thank you for reporting this issue.

Analysis:

You are correct that the current implementation does not allow setting the daily quota to "infinity" (no limit). Based on my analysis of the codebase:

1. Schema Validation (src/lib/validation/schemas.ts, lines 32-37):
   The dailyQuota field in CreateUserSchema has a minimum constraint of 0.01 (from USER_LIMITS.DAILY_QUOTA.MIN):

   dailyQuota: z.coerce
     .number()
     .min(USER_LIMITS.DAILY_QUOTA.MIN, ...)  // MIN = 0.01
     .max(USER_LIMITS.DAILY_QUOTA.MAX, ...)  // MAX = 100,000

2. Form UI (src/app/[locale]/dashboard/_components/user/forms/user-form.tsx, lines 237-246):
   The daily quota field is marked as required with min={USER_LIMITS.DAILY_QUOTA.MIN}:

   <TextField
     label={tForm("dailyQuota.label")}
     type="number"
     required
     min={USER_LIMITS.DAILY_QUOTA.MIN}  // 0.01
     ...
   />

3. Constants (src/lib/constants/user.constants.ts, lines 14-17):

   DAILY_QUOTA: {
     MIN: 0.01,
     MAX: 100_000,  // 100,000 USD
   }

Interestingly, the rate limit service (src/lib/rate-limit/service.ts, lines 889-891) already handles "no limit" correctly:

if (!dailyLimitUsd || dailyLimitUsd <= 0) {
  return { allowed: true }; // 未设置限制 (No limit set)
}

This means the backend logic would properly treat null or 0 as "unlimited", but the schema and form validation prevent these values from being set.

Root Cause:
The schema and form require a minimum value of 0.01 for dailyQuota, preventing users from setting it to 0 or null to indicate "no limit".

Workaround (Current):
Set the daily quota to the maximum allowed value: 100,000 USD.

Potential Fix:
To support "unlimited" daily quota, the following changes would be needed:

• Update USER_LIMITS.DAILY_QUOTA.MIN to 0 in src/lib/constants/user.constants.ts
• Modify the schema to allow null or 0 as valid values
• Update the form UI to handle the "unlimited" state (possibly with a checkbox or special value)

---

Automated response from Claude AI