Conversation
修复正则表达式以同时匹配 "tokens...maximum" 和 "maximum...tokens" 两种格式。 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Summary of ChangesHello @sususu98, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求旨在增强系统识别和分类来自不同 API 响应中“提示过长”错误的能力。通过更新一个关键的正则表达式，系统现在可以处理错误消息中不同词语顺序的情况，确保更一致的错误处理和用户反馈。 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| const DEFAULT_ERROR_RULES = [ | ||
| { | ||
| pattern: "prompt is too long.*maximum.*tokens", | ||
| pattern: "prompt is too long.*(tokens.*maximum|maximum.*tokens)", |
There was a problem hiding this comment.
为了略微提高正则表达式的性能，建议使用非捕获组 (?:...) 来代替捕获组 (...)。非捕获组在匹配时不会保存子字符串，因此效率会更高一些。
| pattern: "prompt is too long.*(tokens.*maximum|maximum.*tokens)", | |
| pattern: "prompt is too long.*(?:tokens.*maximum|maximum.*tokens)", |
🔒 Security Scan Results✅ No security vulnerabilities detected This PR has been scanned against OWASP Top 10, CWE Top 25, and common security anti-patterns. No security issues were identified in the code changes. Change SummaryThe PR modifies a single regex pattern in
This is a pattern improvement to match both word orderings in error messages. Security Analysis
Scanned Categories
Code ContextThe codebase already implements robust ReDoS protection via the 🤖 Automated security scan by Claude AI - OWASP Top 10 & CWE coverage |
ding113
left a comment
ding113
left a comment
There was a problem hiding this comment.
📋 Code Review Summary
This PR improves the prompt_limit error rule regex pattern to handle two different API error message formats. The change is minimal, well-targeted, and correctly implements the stated goal.
🔍 Issues Found
- Critical (🔴): 0 issues
- High (🟠): 0 issues
- Medium (🟡): 0 issues
- Low (🟢): 0 issues
🎯 Priority Actions
No issues requiring action were identified. The change is ready for merge.
💡 General Observations
-
Regex correctness verified: The new pattern
prompt is too long.*(tokens.*maximum|maximum.*tokens)correctly matches both orderings:prompt is too long...tokens...maximum✅prompt is too long...maximum...tokens✅
-
No ReDoS vulnerability: The pattern was tested with adversarial inputs (up to 1000 characters between tokens) and completed in <1ms.
-
Backward compatible: The new pattern matches all strings that the old pattern matched, plus the additional format.
-
Test alignment: The existing test suite uses test strings that align with the new regex pattern, suggesting this change fixes a mismatch between test expectations and implementation.
🤖 Automated review by Claude AI - focused on identifying issues for improvement
ding113
left a comment
ding113
left a comment
There was a problem hiding this comment.
📋 Code Review Summary
This PR improves the prompt_limit error rule regex pattern to handle two different API error message formats. The change is minimal, well-targeted, and correctly implements the stated goal.
🔍 Issues Found
- Critical (🔴): 0 issues
- High (🟠): 0 issues
- Medium (🟡): 0 issues
- Low (🟢): 0 issues
🎯 Priority Actions
No issues requiring action were identified. The change is ready for merge.
💡 General Observations
-
Regex correctness verified: The new pattern
prompt is too long.*(tokens.*maximum|maximum.*tokens)correctly matches both orderings:prompt is too long...tokens...maximum✅prompt is too long...maximum...tokens✅
-
No ReDoS vulnerability: The pattern was tested with adversarial inputs (up to 1000 characters between tokens) and completed in <1ms.
-
Backward compatible: The new pattern matches all strings that the old pattern matched, plus the additional format.
-
Test alignment: The existing test suite uses test strings that align with the new regex pattern, suggesting this change fixes a mismatch between test expectations and implementation.
🤖 Automated review by Claude AI - focused on identifying issues for improvement
2 participants
Summary
prompt is too long...tokens...maximumprompt is too long...maximum...tokensChanges
将原来的
prompt is too long.*maximum.*tokens改为prompt is too long.*(tokens.*maximum|maximum.*tokens)，以覆盖不同 API 返回的错误消息格式。Test plan
🤖 Generated with Claude Code