Closed
Conversation
Fixed: - Updated UpdateUserData and CreateUserData interfaces to accept null for dailyQuota, limit5hUsd, limitWeeklyUsd, limitMonthlyUsd, limitConcurrentSessions - Updated UpdateDbData interface in repository/user.ts to accept null values - Updated function signatures for addUser, editUser, createUserOnly to accept null for dailyQuota - Updated KeyEditSection onChange prop type to support batch updates - Updated emitChange function in user-edit-section.tsx to handle batch updates - Updated unified-edit-dialog.tsx onChange handler to properly type batch updates - Fixed import organization in limit-rule-picker.tsx (auto-fixed by biome) CI Run: https://github.com/ding113/claude-code-hub/actions/runs/20366262485 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
github-project-automation
bot
moved this from Backlog
to Done
in Claude Code Hub Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI Auto-Fix
Original PR: #370
Failed CI Run: PR Build Check
Fixes Applied
src/types/user.tsCreateUserDataandUpdateUserDatainterfaces to acceptnullfordailyQuota,limit5hUsd,limitWeeklyUsd,limitMonthlyUsd,limitConcurrentSessionssrc/repository/user.tsUpdateDbDatainterface to acceptnullfor string quota fieldssrc/actions/users.tsaddUser,editUser,createUserOnlyfunction signatures to acceptnullfordailyQuotasrc/app/.../key-edit-section.tsxonChangeprop type to support both single-field and batch updatessrc/app/.../user-edit-section.tsxemitChangefunction to handle batch updates (object argument)src/app/.../unified-edit-dialog.tsxonChangehandler type annotation for proper batch update supportsrc/app/.../limit-rule-picker.tsxRoot Cause
The Zod validation schemas define fields like
dailyQuota,limit5hUsd, etc. with.nullable().optional()which producesnumber | null | undefined, but the TypeScript interfaces only acceptednumber | undefined. This type mismatch caused the build to fail.Additionally, the
onChangehandlers in form components were being called with batch update objects (single argument) but the type signature only accepted two arguments(field, value).Verification
bun run typecheckpassesbun run lintpassesAuto-generated by Claude AI