Merged
Conversation
Fixed issues: - Updated UpdateUserData type to allow null for quota fields (dailyQuota, limit5hUsd, limitWeeklyUsd, limitMonthlyUsd, limitConcurrentSessions) - Updated UpdateDbData interface to accept null for string quota fields - Updated addUser and editUser function signatures to accept null for dailyQuota - Fixed onChange prop type in KeyEditSection and UserEditSection to use overloaded signature supporting both single-field and batch updates - Updated emitChange helper to properly handle both call patterns - Fixed onChange wrapper in UnifiedEditDialog with proper type casting These changes ensure null values can be properly passed through the type system when clearing quota limits. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
github-project-automation
bot
moved this from Backlog
to Done
in Claude Code Hub Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI Auto-Fix
Original PR: #370
Failed CI Run: PR Build Check
Fixes Applied
src/types/user.tsUpdateUserDatainterface to allownullfor quota fieldssrc/repository/user.tsUpdateDbDatainterface to allownullfor string quota fields andlimitConcurrentSessionssrc/actions/users.tsaddUserandeditUserfunction signatures to acceptnullfordailyQuotasrc/actions/users.ts?? undefinedfordailyQuotaincreateUsercallssrc/app/.../key-edit-section.tsxonChangeprop type to support overloaded signature for batch updatessrc/app/.../user-edit-section.tsxonChangetype andemitChangeto handle batch updatessrc/app/.../unified-edit-dialog.tsxonChangewrapper with proper type castingsrc/app/.../limit-rule-picker.tsxRoot Cause
The TypeScript errors occurred because:
dailyQuota,limit5hUsd, etc.) were being set tonullto clear limits, but type definitions only allowednumber | undefinedonChangeprop was being called with both single-field(field, value)and batch update({...})patterns, but the type only supported the single-field patternVerification
bun run typecheckpassesbun run lintpassesAuto-generated by Claude AI