fix: add my-quota page for non-admin users by ding113 · Pull Request #419 · ding113/claude-code-hub

ding113 · 2025-12-23T16:27:29Z

Summary

Add /dashboard/my-quota page for non-admin users to view their quota (read-only)
Update navigation to show role-specific labels: Admin sees "Quotas", non-admin sees "My Quota"
Unify redirect targets for non-admin users accessing admin quota pages

Closes #412

Test plan

Login as admin user, verify "Quotas" nav links to /dashboard/quotas
Login as non-admin user with canLoginWebUi, verify "My Quota" nav links to /dashboard/my-quota
Verify /dashboard/my-quota displays QuotaCards correctly
Verify non-admin accessing /dashboard/quotas redirects to /dashboard/my-quota
Verify all 5 language translations display correctly

Non-admin users could see "Quotas" nav but were redirected away. Now they see "My Quota" nav linking to a read-only quota view. - Add /dashboard/my-quota page reusing QuotaCards component - Update nav to show role-specific labels and routes - Unify redirect targets for non-admin users - Add i18n keys for all 5 languages Closes #412 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

gemini-code-assist · 2025-12-23T16:27:48Z

Summary of Changes

Hello @ding113, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user experience by providing non-admin users with a personalized view of their quotas through a new 'My Quota' page. It intelligently adjusts the navigation menu based on user roles and standardizes the redirection behavior for non-admin users who might inadvertently try to access admin-specific quota management sections, ensuring they are guided to their relevant quota information.

Highlights

New 'My Quota' Page: A dedicated read-only page has been introduced at /dashboard/my-quota for non-admin users to view their personal quota information.
Role-Based Navigation: The dashboard navigation has been updated to dynamically display 'Quotas' for admin users (linking to /dashboard/quotas) and 'My Quota' for non-admin users (linking to the new /dashboard/my-quota page).
Unified Non-Admin Redirection: Non-admin users attempting to access administrative quota pages (e.g., /dashboard/quotas, /dashboard/quotas/providers, /dashboard/quotas/users) are now consistently redirected to the new /dashboard/my-quota page.
Internationalization Updates: New translation keys for 'My Quota' have been added across multiple language files (English, Japanese, Russian, Simplified Chinese, Traditional Chinese) to support the new feature.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

github-actions · 2025-12-23T16:29:32Z

🧪 测试结果

测试类型	状态
代码质量	✅
单元测试	✅
集成测试	✅
API 测试	✅

总体结果: ✅ 所有测试通过

gemini-code-assist

Code Review

This pull request introduces a dedicated 'My Quota' page for non-admin users, which is a great improvement for user experience. The changes correctly update the navigation to be role-aware and unify redirects for admin-only quota pages. The implementation is solid, including the necessary internationalization updates. I have a couple of suggestions to further improve the code.

gemini-code-assist · 2025-12-23T16:30:10Z

src/app/[locale]/dashboard/_components/dashboard-header.tsx

+    ...(isAdmin
+      ? [{ href: "/dashboard/quotas", label: t("quotasManagement") }]
+      : [{ href: "/dashboard/my-quota", label: t("myQuota") }]),
    { href: "/dashboard/users", label: t("userManagement") },


The userManagement link should only be visible to admin users. You should add adminOnly: true to this navigation item to prevent non-admin users from seeing a link to a page they cannot access. This would make it consistent with the other admin-only links and the changes you've made for the quotas link.

Suggested change

{ href: "/dashboard/users", label: t("userManagement") },

{ href: "/dashboard/users", label: t("userManagement"), adminOnly: true },

gemini-code-assist · 2025-12-23T16:30:10Z

src/app/[locale]/dashboard/my-quota/page.tsx

+        <div>
+          <h3 className="text-lg font-medium">{tNav("myQuota")}</h3>
+        </div>


The inner div element is redundant. You can simplify the structure by placing the h3 element directly inside the flex container.

<h3 className="text-lg font-medium">{tNav("myQuota")}</h3>

- Add error state handling in my-quota page (show Alert instead of empty state) - Fix quotas/keys redirect to /dashboard/my-quota for consistency Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

github-actions

Code Review Summary

No significant issues identified in this PR.

PR Size: M

Lines changed: 46
Files changed: 10

Review Coverage

Automated review by Codex AI

github-actions

Identified open PR #419 and reviewed all diff hunks (46 LOC across 10 files).
Applied label size/M to PR #419.
Submitted a PR review summary comment via gh pr review; no inline comments left because no issues met the ≥80 confidence threshold on changed lines.

github-actions · 2025-12-23T16:37:01Z

🧪 测试结果

测试类型	状态
代码质量	✅
单元测试	✅
集成测试	✅
API 测试	✅

总体结果: ✅ 所有测试通过

Simplifies the JSX structure by removing unnecessary inner div elements in both the error state and success state render paths. Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

github-actions · 2025-12-23T17:28:19Z

🧪 测试结果

测试类型	状态
代码质量	✅
单元测试	✅
集成测试	✅
API 测试	✅

总体结果: ✅ 所有测试通过

github-project-automation bot added this to Claude Code Hub Roadmap Dec 23, 2025

github-project-automation bot moved this to Backlog in Claude Code Hub Roadmap Dec 23, 2025

github-actions bot added enhancement New feature or request area:UI area:i18n labels Dec 23, 2025

github-actions bot added the size/M Medium PR (< 500 lines) label Dec 23, 2025

gemini-code-assist bot reviewed Dec 23, 2025

View reviewed changes

github-actions bot reviewed Dec 23, 2025

View reviewed changes

ding113 merged commit 5d64df3 into dev Dec 23, 2025
7 checks passed

github-project-automation bot moved this from Backlog to Done in Claude Code Hub Roadmap Dec 23, 2025

ding113 deleted the fix/issue-412-quota-page branch December 23, 2025 17:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

fix: add my-quota page for non-admin users#419

fix: add my-quota page for non-admin users#419
ding113 merged 3 commits intodevfrom
fix/issue-412-quota-page

ding113 commented Dec 23, 2025

Uh oh!

gemini-code-assist bot commented Dec 23, 2025

Uh oh!

github-actions bot commented Dec 23, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Dec 23, 2025

Uh oh!

gemini-code-assist bot Dec 23, 2025

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot commented Dec 23, 2025

Uh oh!

Uh oh!

github-actions bot commented Dec 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	{ href: "/dashboard/users", label: t("userManagement") },
	{ href: "/dashboard/users", label: t("userManagement"), adminOnly: true },

Uh oh!

Comments

Conversation

ding113 commented Dec 23, 2025

Summary

Test plan

Uh oh!

gemini-code-assist bot commented Dec 23, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

github-actions bot commented Dec 23, 2025

🧪 测试结果

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Code Review Summary

PR Size: M

Review Coverage

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 23, 2025

🧪 测试结果

Uh oh!

Uh oh!

github-actions bot commented Dec 23, 2025

🧪 测试结果

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant