fix: 修复错误规则测试页面的误报警告

[sususu98]

Summary

Fix false positive warning in error rule test page when override message equals test input.

修复错误规则测试页面的误报警告：当覆写响应的 message 与测试输入相同时，不再误报 "覆写响应的 message 为空"。

Problem

The test page logic incorrectly checks "whether the final message equals the original message" instead of "whether the override message itself is empty".

When the configured override message happens to be the same as the test input, it triggers a false warning.

测试页面判断逻辑有误：检查的是"最终 message 是否等于原始消息"，而不是"覆写的 message 本身是否为空"。当用户配置的覆写 message 恰好与测试输入相同时，会触发误报警告。

Solution

Change the logic to directly check if overrideErrorObj?.message is an empty string.

将判断逻辑改为直接检查 overrideErrorObj?.message 是否为空字符串。

Changes

Core Changes

• src/actions/error-rules.ts: Fix warning condition to check if override message is empty rather than comparing with original message

Testing

Manual Testing

1. Configure an override rule with message set to "test message"
2. Test with input "test message" - verify no warning appears
3. Test with other messages - verify override works correctly
4. Configure an override rule with empty message - verify warning appears

Checklist

• Code follows project conventions
• Self-review completed
• Logic change is minimal and focused

---

Description enhanced by Claude AI

[gemini-code-assist]

Summary of Changes

Hello @sususu98, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在修复错误规则测试页面中的一个逻辑缺陷，该缺陷导致在特定条件下会产生误报警告。通过调整对覆写消息是否为空的判断方式，确保系统能够准确识别用户意图，避免不必要的警告，从而提升测试页面的准确性和用户体验。

Highlights

• 修复误报警告: 解决了错误规则测试页面中，当覆写消息与原始消息相同时，错误地提示“覆写响应的 message 为空”的问题。
• 优化判断逻辑: 将判断逻辑从比较最终消息与原始消息是否相同，改为直接检查覆写消息本身是否为空字符串，从而避免误报。
• 更新日志: 更新了 CHANGELOG.md 文件，增加了 v0.3.36 版本的发布记录，包含多项新增功能、优化和修复。

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

本次 PR 很好地修复了错误规则测试页面中的误报警告问题。通过直接检查 overrideErrorObj?.message 是否为空，而不是与原始消息比较，逻辑变得更加清晰和准确，解决了当覆写消息与原始消息相同时产生的 bug。代码更改是正确的。

我只在 CHANGELOG.md 中添加了一个建议，希望能将本次修复也记录在更新日志中，以保持其完整性。

[github-actions]

Code Review Summary

No significant issues identified in this PR.

This is a well-targeted bug fix that corrects the warning logic in the error rule test function. The original code checked if the final message equals the raw message, which incorrectly triggers a warning when the user's configured override message happens to match the test input. The fix properly checks whether the override message field itself is empty.

PR Size: XS

• Lines changed: 38 (32 additions, 6 deletions)
• Files changed: 2

Changes Reviewed

• CHANGELOG.md: Documentation update (release notes for v0.3.36)
• src/actions/error-rules.ts: Bug fix in testErrorRuleAction function

Analysis

The fix correctly changes the logic from:

// Before: incorrectly checks if final message equals raw message
if (overrideMessage === rawMessage) { warnings.push(...) }

to:

// After: correctly checks if the override message field is empty
const isMessageEmpty = typeof overrideErrorObj?.message !== "string" || 
                       overrideErrorObj.message.trim().length === 0;
if (isMessageEmpty) { warnings.push(...) }

This aligns with the runtime behavior in error-handler.ts:154-159 which uses the same pattern to determine message emptiness.

Review Coverage

• Logic and correctness - Clean
• Security (OWASP Top 10) - Clean
• Error handling - Clean
• Type safety - Clean
• Documentation accuracy - Clean
• Test coverage - N/A (manual test plan provided in PR)
• Code clarity - Good

---

Automated review by Claude AI

[github-actions]

Code Review Summary

No significant issues identified in this PR.

This is a well-targeted bug fix that corrects the warning logic in the error rule test function. The original code checked if the final message equals the raw message, which incorrectly triggers a warning when the user's configured override message happens to match the test input. The fix properly checks whether the override message field itself is empty.

PR Size: XS

• Lines changed: 38 (32 additions, 6 deletions)
• Files changed: 2

Changes Reviewed

• CHANGELOG.md: Documentation update (release notes for v0.3.36)
• src/actions/error-rules.ts: Bug fix in testErrorRuleAction function

Analysis

The fix correctly changes the logic from:

// Before: incorrectly checks if final message equals raw message
if (overrideMessage === rawMessage) { warnings.push(...) }

to:

// After: correctly checks if the override message field is empty
const isMessageEmpty = typeof overrideErrorObj?.message \!== "string" || 
                       overrideErrorObj.message.trim().length === 0;
if (isMessageEmpty) { warnings.push(...) }

This aligns with the runtime behavior in error-handler.ts:154-159 which uses the same pattern to determine message emptiness.

Review Coverage

• Logic and correctness - Clean
• Security (OWASP Top 10) - Clean
• Error handling - Clean
• Type safety - Clean
• Documentation accuracy - Clean
• Test coverage - N/A (manual test plan provided in PR)
• Code clarity - Good

---

Automated review by Claude AI