Fix #550: Add error rule for tool_use missing tool_result#551
Conversation
Add new error rule to handle the case where a `tool_use` block is missing its corresponding `tool_result` in the next message. This is the reverse direction of the existing rule for `tool_result` missing `tool_use`. The new pattern matches: - `tool_use` ids were found without `tool_result` blocks immediately after - Each `tool_use` block must have a corresponding `tool_result` block Closes #550 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Summary of ChangesHello @ding113, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a crucial enhancement to the error handling mechanism by adding a new rule to detect and manage a specific Claude API error. Previously, the system would not correctly identify when a 'tool_use' block lacked its required 'tool_result' in the subsequent message, leading to inefficient retries. The new rule ensures that such validation errors are properly categorized, communicated to the user in a clear message, and prevent further incorrect processing. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📝 Walkthrough总览在 变更内容
代码审查工作量评估🎯 2 (Simple) | ⏱️ ~10 分钟 可能相关的 PR
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new error rule to handle cases where a tool_use block is missing its corresponding tool_result. This is a valuable addition that correctly categorizes a client-side error as non-retryable, preventing unnecessary provider switching. The implementation is clean and consistent with the existing error rule structure. I have one minor suggestion to refactor the regular expression for improved readability and a slight performance gain. Overall, this is a well-executed fix.
| pattern: | ||
| "tool_use.*ids were found without.*tool_result.*immediately after|tool_use.*block must have.*corresponding.*tool_result.*block in the next message", |
There was a problem hiding this comment.
The regex pattern can be slightly refactored to improve readability and performance by factoring out the common tool_use.* prefix. This avoids repeating the prefix and makes the regex engine's job slightly easier by using a non-capturing group for the alternatives.
| pattern: | |
| "tool_use.*ids were found without.*tool_result.*immediately after|tool_use.*block must have.*corresponding.*tool_result.*block in the next message", | |
| pattern: | |
| "tool_use.*(?:ids were found without.*tool_result.*immediately after|block must have.*corresponding.*tool_result.*block in the next message)", |
github-actions
bot
added
bug
🧪 测试结果
总体结果: ✅ 所有测试通过 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/repository/error-rules.ts (1)
527-545: 新规则实现正确，符合设计目标。此规则正确地匹配了 Issue #550 中描述的 API 错误场景，将其归类为
validation_error（客户端错误），避免了不必要的重试和供应商切换。实现遵循了现有规则的模式，用户提示信息清晰明确。不过，建议考虑以下优化：
- 正则表达式性能优化：当前模式使用贪婪匹配
.*，在极长的错误消息中可能影响性能。建议使用非贪婪匹配.*?或更具体的字符类（如\s+、\w+）。- 优先级冲突提醒：新规则的优先级（88）与上方的 tool_result 验证规则相同，且两者都属于
validation_error类别。虽然不影响功能（按插入顺序处理），但如果未来需要调整匹配顺序，可能需要区分优先级。🔎 可选的正则表达式优化建议
{ pattern: - "tool_use.*ids were found without.*tool_result.*immediately after|tool_use.*block must have.*corresponding.*tool_result.*block in the next message", + "tool_use.*?ids were found without.*?tool_result.*?immediately after|tool_use.*?block must have.*?corresponding.*?tool_result.*?block in the next message", category: "validation_error", description: "tool_use block missing corresponding tool_result in next message (client error)",
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to Reviews > Disable Cache setting
📒 Files selected for processing (1)
src/repository/error-rules.ts
🧰 Additional context used
📓 Path-based instructions (6)
**/*.{ts,tsx,js,jsx,json}
📄 CodeRabbit inference engine (CLAUDE.md)
Use 2-space indentation in all code files
Files:
src/repository/error-rules.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx,js,jsx}: Use double quotes for strings instead of single quotes
Use trailing commas in multi-line structures
Enforce maximum line length of 100 characters
Use path alias@/*to reference files from./src/*directory
**/*.{ts,tsx,js,jsx}: Use Biome for linting and formatting with 2-space indent, double quotes, trailing commas, and 100 character max line length
Use path alias@/*to reference files in./src/*directory
Files:
src/repository/error-rules.ts
src/repository/**/*.ts
📄 CodeRabbit inference engine (CLAUDE.md)
Use Repository pattern in
src/repository/to wrap Drizzle queries
Files:
src/repository/error-rules.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx}: Use TypeScript strict mode for type safety
Use readonly or const assertions for immutable data structures
Files:
src/repository/error-rules.ts
src/**/*.ts
📄 CodeRabbit inference engine (AGENTS.md)
src/**/*.ts: Hash API keys using SHA-256 before storing in database, never store plaintext keys
Mask API keys and sensitive data in application logs
Validate required environment variables at startup with clear error messages
Files:
src/repository/error-rules.ts
src/{repository,actions}/**/*.ts
📄 CodeRabbit inference engine (AGENTS.md)
Avoid N+1 queries by using eager loading and batch queries for statistics
Files:
src/repository/error-rules.ts
🧠 Learnings (1)
📚 Learning: 2026-01-05T03:01:39.354Z
Learnt from: NieiR
Repo: ding113/claude-code-hub PR: 539
File: src/types/user.ts:158-170
Timestamp: 2026-01-05T03:01:39.354Z
Learning: In TypeScript interfaces, explicitly document and enforce distinct meanings for null and undefined. Example: for numeric limits like limitTotalUsd, use 'number | null | undefined' when null signifies explicitly unlimited (e.g., matches DB schema or special UI logic) and undefined signifies 'inherit default'. This pattern should be consistently reflected in type definitions across related fields to preserve semantic clarity between database constraints and UI behavior.
Applied to files:
src/repository/error-rules.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Greptile Review
- GitHub Check: pr-description
- GitHub Check: 🌐 API Tests
- GitHub Check: pr-review
- GitHub Check: check-codex-status
- GitHub Check: Docker Build Test
- GitHub Check: dev-build-deploy
🔇 Additional comments (2)
src/repository/error-rules.ts (2)
536-536: 注意：优先级值与相邻规则重复。新规则的优先级（88）与上方第 518 行的 tool_result 验证规则相同，且两者都属于
validation_error类别。根据第 109 行的排序逻辑[errorRules.priority, errorRules.category]，当优先级和类别都相同时，规则的匹配顺序将取决于数据库插入顺序或 ID。虽然这不影响当前功能（两个规则匹配不同的错误场景），但如果未来需要明确控制这两条规则的检测顺序，建议为其中一条分配不同的优先级值（例如 87 或 89）。
基于代码审查指南：这是优先级管理的最佳实践建议。
529-530: 正则表达式的特异性已验证。该模式包含多个关键词序列，在错误消息匹配中具有足够的特异性。第二个分支虽然使用.*进行灵活匹配，但包含了多个显著的关键词组合（"block must have"、"corresponding"、"block in the next message"），这与文件中其他类似模式（如 Issue #471）的设计一致。缺乏实际错误消息示例或假阳性匹配的证据。建议保留当前模式，除非在实际使用中发现误匹配问题。
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Summary
No significant issues identified in this PR.
PR Size: XS
- Lines changed: 19
- Files changed: 1
Review Coverage
- Logic and correctness - Clean
- Security (OWASP Top 10) - Clean
- Error handling - Clean
- Type safety - Clean
- Documentation accuracy - Clean
- Test coverage - Adequate
- Code clarity - Good
Automated review by Codex AI
github-project-automation
bot
moved this from Backlog
to Done
in Claude Code Hub Roadmap
1 participant
Summary
tool_useblocks missing correspondingtool_resultin next messagetool_resultmissingtool_useProblem
Fixes #550
When a request contains a
tool_useblock without a correspondingtool_resultin the immediately following message, Claude API returns:This error was not covered by existing rules, causing unnecessary retries and provider switching.
Solution
Added a new regex error rule with pattern:
This rule:
validation_errorChanges
src/repository/error-rules.ts: Added new error rule for Issue 添加错误规则：Eachtool_useblock must have a correspondingtool_resultblock in the next message #550Testing
Created by Claude AI in response to @claude mention
Greptile Summary
This PR adds a new error rule to handle validation errors when a
tool_useblock is missing its correspondingtool_resultin the next message. The implementation is clean and follows the existing patterns in the codebase:validation_error(non-retryable client error)tool_resultvalidation rule on line 518The implementation is consistent with the reverse error case (line 510-526) and properly prevents unnecessary retries for this client-side validation error.
Confidence Score: 5/5
Important Files Changed
tool_usemissingtool_resultvalidation - pattern is correct and consistent with existing rulesSequence Diagram
sequenceDiagram participant Client participant ErrorDetector participant ClaudeAPI participant Database Note over Client,Database: Error Rule Synchronization on Startup Client->>Database: syncDefaultErrorRules() Database-->>Client: Insert/Update new rule #550 Note over Client,Database: Request Processing Flow Client->>ClaudeAPI: Send request with tool_use block ClaudeAPI-->>Client: Error: tool_use missing tool_result Client->>ErrorDetector: Match error message ErrorDetector->>Database: Query active error rules (priority 88) Database-->>ErrorDetector: Return rule #550 pattern ErrorDetector->>ErrorDetector: Regex match: tool_use.*ids were found without.*tool_result ErrorDetector-->>Client: Override response (validation_error) Note over Client: No retry - client-side validation error Client-->>Client: Return user-friendly Chinese message