PR: fix(db): make drizzle migrations idempotent#578
Conversation
Use ADD COLUMN IF NOT EXISTS in 0044_uneven_donald_blake.sql (line 1) Use ADD COLUMN IF NOT EXISTS in 0049_shocking_ultimatum.sql (line 1) Use ADD COLUMN IF NOT EXISTS in 0050_flippant_jack_flag.sql (line 1) Use ADD COLUMN IF NOT EXISTS in 0051_silent_maelstrom.sql (line 1) Use ADD COLUMN IF NOT EXISTS in 0052_model_price_source.sql (line 1)
📝 Walkthrough演练在gitignore中添加了 变更
预估代码审查工作量🎯 1 (Trivial) | ⏱️ ~3分钟 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
Summary of ChangesHello @YangQing-Lin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求旨在解决本地开发环境中 Drizzle 数据库迁移的稳定性问题。通过修改现有的迁移脚本，使其在添加新列时具备幂等性，即当目标列已存在时，迁移操作将安全跳过而非抛出错误。这显著提升了开发工作流的顺畅性，避免了因重复执行迁移而导致的启动失败，从而为开发者提供了更可靠的数据库初始化体验。 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
您好，感谢您为解决数据库迁移幂等性问题所做的贡献。
本次 PR 的目标非常明确，即通过将 ADD COLUMN 修改为 ADD COLUMN IF NOT EXISTS 来避免在开发环境重复执行迁移时出错。您提交的修改是正确且有效的，能够解决所述问题。此外，我注意到您在修改 SQL 文件的同时，也为文件末尾添加了换行符，这是一个很好的实践。
有一个小问题需要您确认：PR 描述中提到了对 drizzle/0044_uneven_donald_blake.sql 文件的修改，但在本次提交的变更中似乎并未包含该文件。请检查一下是否遗漏了此文件的提交。
总体而言，这是一个高质量的修复，解决了开发流程中的一个痛点。在确认文件完整性并考虑我提出的建议后，即可合入。
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
github-project-automation
bot
moved this from Backlog
to Done
in Claude Code Hub Roadmap
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Summary
No significant issues identified in this PR.
PR Size: S
- Lines changed: 13
- Files changed: 5
Review Coverage
- Logic and correctness - Clean
- Security (OWASP Top 10) - Clean
- Error handling - Clean
- Type safety - Clean
- Documentation accuracy - Clean
- Test coverage - Adequate
- Code clarity - Good
Automated review by Codex AI
There was a problem hiding this comment.
- Reviewed PR
#578(fix/drizzle-migrations-idempotent) diff (5files,13lines changed). - Applied PR size label:
size/S. - Submitted a PR review comment via
gh pr review(no inline comments posted because no issues met the reporting threshold in the diff).
- PR ding113#580: TOML cloud price table + billing fail-open - PR ding113#578: make drizzle migrations idempotent - PR ding113#577: fix thinking enabled + tool_use first block - PR ding113#573: add manual model price management Conflict resolutions: - drizzle migrations: use upstream idempotent version - i18n messages: accept upstream additions - price-sync.ts: removed (replaced by cloud-price-table) - model-prices.ts: use upstream refactored version
2 participants
Summary
Makes Drizzle migrations idempotent by adding
IF NOT EXISTStoADD COLUMNstatements, preventing "column already exists" errors during local development startup.Problem
Local development startup (
bun run dev) auto-executes Drizzle migrations. When certain columns already exist in the database, the corresponding migrations still attemptADD COLUMN, causing errors likecolumn ... already existsand failing the dev environment startup.Related Issues/PRs:
IF NOT EXISTSto CREATE INDEX statements for idempotencySolution
Modified migration files to use
ADD COLUMN IF NOT EXISTSsyntax, allowing migrations to skip safely when columns already exist.Changes
Migration Files Updated
drizzle/0049_shocking_ultimatum.sqlspecial_settingsdrizzle/0050_flippant_jack_flag.sqlenable_response_fixer,response_fixer_configdrizzle/0051_silent_maelstrom.sqlenable_thinking_signature_rectifierdrizzle/0052_model_price_source.sqlsource(index already usesIF NOT EXISTS)Other Changes
.gitignore: Added.codex/directoryBreaking Changes
None.
IF NOT EXISTSonly affects migrations when columns already exist - it does not modify column types, defaults, or constraints.Risks & Trade-offs
IF NOT EXISTSonly skips when "column already exists", it will NOT auto-correct schema drift (e.g., mismatched types/defaults/NOT NULL). If alignment is needed, explicitALTER COLUMN ...migrations should be added.Testing
Manual Testing
bun run dev # or just migrations: bun run db:migrateExpected: Migrations complete without "column already exists" errors.
Note: The author mentioned this fix was created after manually interrupting a dev startup, so a full startup cycle should be verified.
Checklist
bun run test)Description enhanced by Claude AI