-
-
Notifications
You must be signed in to change notification settings - Fork 181
Fix provider exhaustion after model redirect (refs #629) #633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -418,6 +418,17 @@ export function transformClaudeNonStreamResponseToOpenAI( | |||||||||||||
| }, | ||||||||||||||
| }); | ||||||||||||||
| break; | ||||||||||||||
|
|
||||||||||||||
| case "tool_result": { | ||||||||||||||
| // tool_result blocks do not have a .text field; they carry data in .content. | ||||||||||||||
| // This is typically present in requests, but some proxies may echo it in responses. | ||||||||||||||
| // Ignore for OpenAI chat completions output. | ||||||||||||||
| break; | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| default: | ||||||||||||||
| // Unknown block types are ignored for non-stream output. | ||||||||||||||
| break; | ||||||||||||||
|
Comment on lines
+429
to
+431
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar to the Claude-to-Codex converter, silently ignoring unknown block types in the
Suggested change
|
||||||||||||||
| } | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -239,7 +239,7 @@ export class ProxyProviderResolver { | |
| targetType: reusedProvider.providerType as NonNullable< | ||
| ProviderChainItem["decisionContext"] | ||
| >["targetType"], | ||
| requestedModel: session.getCurrentModel() || "", | ||
| requestedModel: session.getOriginalModel() || "", | ||
| groupFilterApplied: false, | ||
| beforeHealthCheck: 0, | ||
| afterHealthCheck: 0, | ||
|
|
@@ -322,7 +322,7 @@ export class ProxyProviderResolver { | |
| targetType: session.provider.providerType as NonNullable< | ||
| ProviderChainItem["decisionContext"] | ||
| >["targetType"], | ||
| requestedModel: session.getCurrentModel() || "", | ||
| requestedModel: session.getOriginalModel() || "", | ||
| groupFilterApplied: false, | ||
| beforeHealthCheck: 0, | ||
| afterHealthCheck: 0, | ||
|
|
@@ -379,7 +379,7 @@ export class ProxyProviderResolver { | |
| targetType: session.provider.providerType as NonNullable< | ||
| ProviderChainItem["decisionContext"] | ||
| >["targetType"], | ||
| requestedModel: session.getCurrentModel() || "", | ||
| requestedModel: session.getOriginalModel() || "", | ||
| groupFilterApplied: false, | ||
| beforeHealthCheck: 0, | ||
| afterHealthCheck: 0, | ||
|
|
@@ -540,7 +540,7 @@ export class ProxyProviderResolver { | |
| } | ||
|
|
||
| // 检查模型支持(使用新的模型匹配逻辑) | ||
| const requestedModel = session.getCurrentModel(); | ||
| const requestedModel = session.getOriginalModel(); | ||
| if (requestedModel && !providerSupportsModel(provider, requestedModel)) { | ||
| logger.debug("ProviderSelector: Session provider does not support requested model", { | ||
| sessionId: session.sessionId, | ||
|
|
@@ -648,7 +648,7 @@ export class ProxyProviderResolver { | |
| // 使用 Session 快照保证故障迁移期间数据一致性 | ||
| // 如果没有 session,回退到 findAllProviders(内部已使用缓存) | ||
| const allProviders = session ? await session.getProvidersSnapshot() : await findAllProviders(); | ||
| const requestedModel = session?.getCurrentModel() || ""; | ||
| const requestedModel = session?.getOriginalModel() || ""; | ||
|
|
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [HIGH] [TEST-MISSING-CRITICAL] No regression test for model-redirect provider selection Why this is a problem: This change switches provider filtering to use Suggested fix: // tests/unit/proxy/provider-selector-model-redirect.test.ts
import { describe, expect, test, vi } from "vitest";
import type { Provider } from "@/types/provider";
import { ProxyProviderResolver } from "@/app/v1/_lib/proxy/provider-selector";
describe("ProxyProviderResolver.pickRandomProvider - model redirect", () => {
test("filters providers using the original model (not redirected current model)", async () => {
vi.spyOn(ProxyProviderResolver as any, "filterByLimits").mockImplementation(
async (providers: Provider[]) => providers
);
vi.spyOn(ProxyProviderResolver as any, "selectTopPriority").mockImplementation(
(providers: Provider[]) => providers
);
vi.spyOn(ProxyProviderResolver as any, "selectOptimal").mockImplementation(
(providers: Provider[]) => providers[0] as Provider
);
const providers: Provider[] = [
{
id: 1,
name: "p1",
isEnabled: true,
providerType: "claude",
groupTag: null,
weight: 1,
priority: 0,
costMultiplier: 1,
allowedModels: ["claude-test"],
} as unknown as Provider,
];
const session = {
originalFormat: "claude",
authState: null,
getProvidersSnapshot: async () => providers,
getOriginalModel: () => "claude-test",
getCurrentModel: () => "glm-test",
clientRequestsContext1m: () => false,
} as any;
const { provider, context } = await (ProxyProviderResolver as any).pickRandomProvider(
session,
[]
);
expect(context.requestedModel).toBe("claude-test");
expect(provider?.id).toBe(1);
});
}); |
||
| // === Step 1: 分组预过滤(静默,用户只能看到自己分组内的供应商)=== | ||
| const effectiveGroupPick = getEffectiveProviderGroup(session); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| import { describe, expect, it } from "vitest"; | ||
| import { transformClaudeNonStreamResponseToOpenAI } from "@/app/v1/_lib/converters/openai-to-claude/response"; | ||
| import { transformClaudeNonStreamResponseToCodex } from "@/app/v1/_lib/converters/claude-to-codex/response"; | ||
|
|
||
| function createCtx(): any { | ||
| return null; | ||
| } | ||
|
|
||
| describe("Non-stream converters tolerate tool_result blocks", () => { | ||
| it("Claude->OpenAI: ignores tool_result without crashing", () => { | ||
| const response = { | ||
| type: "message", | ||
| id: "msg_1", | ||
| model: "claude-test", | ||
| stop_reason: "end_turn", | ||
| usage: { input_tokens: 1, output_tokens: 1 }, | ||
| content: [ | ||
| { type: "text", text: "hello" }, | ||
| { type: "tool_result", tool_use_id: "toolu_1", content: "ok" }, | ||
| { type: "text", text: " world" }, | ||
| ], | ||
| } as Record<string, unknown>; | ||
|
|
||
| const out = transformClaudeNonStreamResponseToOpenAI( | ||
| createCtx(), | ||
| "claude-test", | ||
| {}, | ||
| {}, | ||
| response | ||
| ); | ||
|
|
||
| expect(out).toMatchObject({ | ||
| object: "chat.completion", | ||
| choices: [ | ||
| { | ||
| message: { | ||
| role: "assistant", | ||
| content: "hello world", | ||
| }, | ||
| }, | ||
| ], | ||
| }); | ||
| }); | ||
|
|
||
| it("Claude->Codex: ignores tool_result without crashing", () => { | ||
| const response = { | ||
| type: "message", | ||
| id: "msg_1", | ||
| model: "claude-test", | ||
| stop_reason: "end_turn", | ||
| usage: { input_tokens: 1, output_tokens: 1 }, | ||
| content: [ | ||
| { type: "text", text: "hello" }, | ||
| { type: "tool_result", tool_use_id: "toolu_1", content: [{ type: "text", text: "ok" }] }, | ||
| { type: "tool_use", id: "toolu_2", name: "do", input: { a: 1 } }, | ||
| ], | ||
| } as Record<string, unknown>; | ||
|
|
||
| const out = transformClaudeNonStreamResponseToCodex( | ||
| createCtx(), | ||
| "claude-test", | ||
| {}, | ||
| {}, | ||
| response | ||
| ); | ||
|
|
||
| expect(out).toMatchObject({ | ||
| type: "response.completed", | ||
| response: { | ||
| type: "response", | ||
| output: [ | ||
| { | ||
| type: "message", | ||
| role: "assistant", | ||
| content: [{ type: "output_text", text: "hello" }], | ||
| }, | ||
| { | ||
| type: "function_call", | ||
| call_id: "toolu_2", | ||
| name: "do", | ||
| }, | ||
| ], | ||
| }, | ||
| }); | ||
| }); | ||
| }); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| import { describe, expect, test, vi } from "vitest"; | ||
| import type { Provider } from "@/types/provider"; | ||
|
|
||
| const circuitBreakerMocks = vi.hoisted(() => ({ | ||
| isCircuitOpen: vi.fn(async () => false), | ||
| getCircuitState: vi.fn(() => "closed"), | ||
| })); | ||
|
|
||
| vi.mock("@/lib/circuit-breaker", () => circuitBreakerMocks); | ||
|
|
||
| describe("ProxyProviderResolver.pickRandomProvider - model redirect", () => { | ||
| test("filters providers using original model (not redirected current model)", async () => { | ||
| const { ProxyProviderResolver } = await import("@/app/v1/_lib/proxy/provider-selector"); | ||
|
|
||
| vi.spyOn(ProxyProviderResolver as any, "filterByLimits").mockImplementation( | ||
| async (...args: unknown[]) => args[0] as Provider[] | ||
| ); | ||
|
|
||
| const providers: Provider[] = [ | ||
| { | ||
| id: 1, | ||
| name: "p1", | ||
| isEnabled: true, | ||
| providerType: "claude", | ||
| groupTag: null, | ||
| weight: 1, | ||
| priority: 0, | ||
| costMultiplier: 1, | ||
| allowedModels: ["claude-test"], | ||
| } as unknown as Provider, | ||
| ]; | ||
|
|
||
| const session = { | ||
| originalFormat: "claude", | ||
| authState: null, | ||
| getProvidersSnapshot: async () => providers, | ||
| getOriginalModel: () => "claude-test", | ||
| getCurrentModel: () => "glm-test", | ||
| clientRequestsContext1m: () => false, | ||
| } as any; | ||
|
|
||
| const { provider, context } = await (ProxyProviderResolver as any).pickRandomProvider( | ||
| session, | ||
| [] | ||
| ); | ||
|
|
||
| expect(context.requestedModel).toBe("claude-test"); | ||
| expect(provider?.id).toBe(1); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
defaultcase currently ignores unknown block types. While this prevents crashes, it might be beneficial to log a warning if an unknown block type is encountered. This would provide better observability and help detect if new, potentially important, block types are introduced by the Claude API that should be explicitly handled by the converter.