Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/app/v1/_lib/converters/claude-to-codex/response.ts
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,16 @@ export function transformClaudeNonStreamResponseToCodex(
});
break;
}

case "tool_result": {
// tool_result blocks belong to tool execution results; Codex Responses output is
// derived from assistant message/tool_use. Ignore if present in Claude response.
break;
}

default:
// Unknown block types are ignored for non-stream output.
break;
Comment on lines +407 to +409
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The default case currently ignores unknown block types. While this prevents crashes, it might be beneficial to log a warning if an unknown block type is encountered. This would provide better observability and help detect if new, potentially important, block types are introduced by the Claude API that should be explicitly handled by the converter.

Suggested change
default:
// Unknown block types are ignored for non-stream output.
break;
default:
logger.warn("[Claude->Codex] Unknown content block type encountered", { blockType });
break;

}
}
}
Expand Down
11 changes: 11 additions & 0 deletions src/app/v1/_lib/converters/openai-to-claude/response.ts
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,17 @@ export function transformClaudeNonStreamResponseToOpenAI(
},
});
break;

case "tool_result": {
// tool_result blocks do not have a .text field; they carry data in .content.
// This is typically present in requests, but some proxies may echo it in responses.
// Ignore for OpenAI chat completions output.
break;
}

default:
// Unknown block types are ignored for non-stream output.
break;
Comment on lines +429 to +431
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the Claude-to-Codex converter, silently ignoring unknown block types in the default case could lead to missed opportunities for handling new API features or debugging unexpected responses. Consider adding a warning log here.

Suggested change
default:
// Unknown block types are ignored for non-stream output.
break;
default:
logger.warn("[Claude->OpenAI] Unknown content block type encountered", { blockType });
break;

}
}

Expand Down
10 changes: 5 additions & 5 deletions src/app/v1/_lib/proxy/provider-selector.ts
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ export class ProxyProviderResolver {
targetType: reusedProvider.providerType as NonNullable<
ProviderChainItem["decisionContext"]
>["targetType"],
requestedModel: session.getCurrentModel() || "",
requestedModel: session.getOriginalModel() || "",
groupFilterApplied: false,
beforeHealthCheck: 0,
afterHealthCheck: 0,
Expand Down Expand Up @@ -322,7 +322,7 @@ export class ProxyProviderResolver {
targetType: session.provider.providerType as NonNullable<
ProviderChainItem["decisionContext"]
>["targetType"],
requestedModel: session.getCurrentModel() || "",
requestedModel: session.getOriginalModel() || "",
groupFilterApplied: false,
beforeHealthCheck: 0,
afterHealthCheck: 0,
Expand Down Expand Up @@ -379,7 +379,7 @@ export class ProxyProviderResolver {
targetType: session.provider.providerType as NonNullable<
ProviderChainItem["decisionContext"]
>["targetType"],
requestedModel: session.getCurrentModel() || "",
requestedModel: session.getOriginalModel() || "",
groupFilterApplied: false,
beforeHealthCheck: 0,
afterHealthCheck: 0,
Expand Down Expand Up @@ -540,7 +540,7 @@ export class ProxyProviderResolver {
}

// 检查模型支持(使用新的模型匹配逻辑)
const requestedModel = session.getCurrentModel();
const requestedModel = session.getOriginalModel();
if (requestedModel && !providerSupportsModel(provider, requestedModel)) {
logger.debug("ProviderSelector: Session provider does not support requested model", {
sessionId: session.sessionId,
Expand Down Expand Up @@ -648,7 +648,7 @@ export class ProxyProviderResolver {
// 使用 Session 快照保证故障迁移期间数据一致性
// 如果没有 session,回退到 findAllProviders(内部已使用缓存)
const allProviders = session ? await session.getProvidersSnapshot() : await findAllProviders();
const requestedModel = session?.getCurrentModel() || "";
const requestedModel = session?.getOriginalModel() || "";

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] [TEST-MISSING-CRITICAL] No regression test for model-redirect provider selection

Why this is a problem: This change switches provider filtering to use session.getOriginalModel() instead of the (potentially redirected) current model. This is core failover behavior; without a unit test that simulates currentModel being redirected (e.g. claude-* -> glm-*) while originalModel remains claude-*, it is easy to reintroduce the "no available providers" exhaustion bug during future refactors.

Suggested fix:

// tests/unit/proxy/provider-selector-model-redirect.test.ts
import { describe, expect, test, vi } from "vitest";
import type { Provider } from "@/types/provider";
import { ProxyProviderResolver } from "@/app/v1/_lib/proxy/provider-selector";

describe("ProxyProviderResolver.pickRandomProvider - model redirect", () => {
  test("filters providers using the original model (not redirected current model)", async () => {
    vi.spyOn(ProxyProviderResolver as any, "filterByLimits").mockImplementation(
      async (providers: Provider[]) => providers
    );
    vi.spyOn(ProxyProviderResolver as any, "selectTopPriority").mockImplementation(
      (providers: Provider[]) => providers
    );
    vi.spyOn(ProxyProviderResolver as any, "selectOptimal").mockImplementation(
      (providers: Provider[]) => providers[0] as Provider
    );

    const providers: Provider[] = [
      {
        id: 1,
        name: "p1",
        isEnabled: true,
        providerType: "claude",
        groupTag: null,
        weight: 1,
        priority: 0,
        costMultiplier: 1,
        allowedModels: ["claude-test"],
      } as unknown as Provider,
    ];

    const session = {
      originalFormat: "claude",
      authState: null,
      getProvidersSnapshot: async () => providers,
      getOriginalModel: () => "claude-test",
      getCurrentModel: () => "glm-test",
      clientRequestsContext1m: () => false,
    } as any;

    const { provider, context } = await (ProxyProviderResolver as any).pickRandomProvider(
      session,
      []
    );

    expect(context.requestedModel).toBe("claude-test");
    expect(provider?.id).toBe(1);
  });
});

// === Step 1: 分组预过滤(静默,用户只能看到自己分组内的供应商)===
const effectiveGroupPick = getEffectiveProviderGroup(session);
Expand Down
86 changes: 86 additions & 0 deletions tests/unit/proxy/converters-tool-result-nonstream.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
import { describe, expect, it } from "vitest";
import { transformClaudeNonStreamResponseToOpenAI } from "@/app/v1/_lib/converters/openai-to-claude/response";
import { transformClaudeNonStreamResponseToCodex } from "@/app/v1/_lib/converters/claude-to-codex/response";

function createCtx(): any {
return null;
}

describe("Non-stream converters tolerate tool_result blocks", () => {
it("Claude->OpenAI: ignores tool_result without crashing", () => {
const response = {
type: "message",
id: "msg_1",
model: "claude-test",
stop_reason: "end_turn",
usage: { input_tokens: 1, output_tokens: 1 },
content: [
{ type: "text", text: "hello" },
{ type: "tool_result", tool_use_id: "toolu_1", content: "ok" },
{ type: "text", text: " world" },
],
} as Record<string, unknown>;

const out = transformClaudeNonStreamResponseToOpenAI(
createCtx(),
"claude-test",
{},
{},
response
);

expect(out).toMatchObject({
object: "chat.completion",
choices: [
{
message: {
role: "assistant",
content: "hello world",
},
},
],
});
});

it("Claude->Codex: ignores tool_result without crashing", () => {
const response = {
type: "message",
id: "msg_1",
model: "claude-test",
stop_reason: "end_turn",
usage: { input_tokens: 1, output_tokens: 1 },
content: [
{ type: "text", text: "hello" },
{ type: "tool_result", tool_use_id: "toolu_1", content: [{ type: "text", text: "ok" }] },
{ type: "tool_use", id: "toolu_2", name: "do", input: { a: 1 } },
],
} as Record<string, unknown>;

const out = transformClaudeNonStreamResponseToCodex(
createCtx(),
"claude-test",
{},
{},
response
);

expect(out).toMatchObject({
type: "response.completed",
response: {
type: "response",
output: [
{
type: "message",
role: "assistant",
content: [{ type: "output_text", text: "hello" }],
},
{
type: "function_call",
call_id: "toolu_2",
name: "do",
},
],
},
});
});
});
50 changes: 50 additions & 0 deletions tests/unit/proxy/provider-selector-model-redirect.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
import { describe, expect, test, vi } from "vitest";
import type { Provider } from "@/types/provider";

const circuitBreakerMocks = vi.hoisted(() => ({
isCircuitOpen: vi.fn(async () => false),
getCircuitState: vi.fn(() => "closed"),
}));

vi.mock("@/lib/circuit-breaker", () => circuitBreakerMocks);

describe("ProxyProviderResolver.pickRandomProvider - model redirect", () => {
test("filters providers using original model (not redirected current model)", async () => {
const { ProxyProviderResolver } = await import("@/app/v1/_lib/proxy/provider-selector");

vi.spyOn(ProxyProviderResolver as any, "filterByLimits").mockImplementation(
async (...args: unknown[]) => args[0] as Provider[]
);

const providers: Provider[] = [
{
id: 1,
name: "p1",
isEnabled: true,
providerType: "claude",
groupTag: null,
weight: 1,
priority: 0,
costMultiplier: 1,
allowedModels: ["claude-test"],
} as unknown as Provider,
];

const session = {
originalFormat: "claude",
authState: null,
getProvidersSnapshot: async () => providers,
getOriginalModel: () => "claude-test",
getCurrentModel: () => "glm-test",
clientRequestsContext1m: () => false,
} as any;

const { provider, context } = await (ProxyProviderResolver as any).pickRandomProvider(
session,
[]
);

expect(context.requestedModel).toBe("claude-test");
expect(provider?.id).toBe(1);
});
});
1 change: 1 addition & 0 deletions tests/unit/proxy/provider-selector-total-limit.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ describe("ProxyProviderResolver.findReusable - provider total limit", () => {
shouldReuseProvider: () => true,
authState: null,
getCurrentModel: () => null,
getOriginalModel: () => null,
} as any;

const reused = await (ProxyProviderResolver as any).findReusable(session);
Expand Down