Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to contribute to the wiki page? #1540

Closed
vaxilicaihouxian opened this issue Mar 15, 2018 · 3 comments
Closed

how to contribute to the wiki page? #1540

vaxilicaihouxian opened this issue Mar 15, 2018 · 3 comments

Comments

@vaxilicaihouxian
Copy link

vaxilicaihouxian commented Mar 15, 2018

Q A
Bug? no
New Feature? no
Framework Lumen
Framework version 5.6
Package version 1.x.y
PHP version 7.1

Actual Behaviour

How to contribute to the wiki page? Because that I found if I follow the [Response Builder].(https://github.com/dingo/api/wiki/Responses)

use Dingo\Api\Routing\Helpers;
use Illuminate\Routing\Controller;

class BaseController extends Controller
{
	use Helpers;
}

Then this controller is not an instance of Laravel\Lumen\Routing\Controller.So some method can not work.Like middleware().

Expected Behaviour

I think it should extends the Laravel\Lumen\Routing\Controller for lumen.Or just extends App\HTTP\Controllers\Controller for laravel and lumen.

Steps to Reproduce

Possible Solutions

So,if this is necessary to change the wiki page,could someone tell me how to contribute for wiki page?

@thilanga
Copy link
Member

thilanga commented Mar 15, 2018

@vaxilicaihouxian

  1. fork the repo.
  2. clone https://github.com/dingo/api.wiki.git
  3. push to github once changes are done
  4. open a PR

@vaxilicaihouxian
Copy link
Author

@thilanga

When I clone the repo (https://github.com/dingo/api.wiki.git) and change it.I push to the repo.
Then I got this error.

Username for 'https://github.com': vaxilicaihouxian
Password for 'https://vaxilicaihouxian@github.com': 
remote: Permission to dingo/api.wiki.git denied to vaxilicaihouxian.
fatal: unable to access 'https://github.com/dingo/api.wiki.git/': The requested URL returned error: 403

@vaxilicaihouxian
Copy link
Author

Already make a pr.
PS: https://github.com/dingo/api-docs is the wiki project source.So I should clone that repo :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants