Added ability to specify the username column for Basic Authentication Provider in config #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, for some reason I thought this was configured elsewhere. I think we'll tackle this a bit differently, mainly because I feel the authentication isn't quite right yet. Going to work on this now. |
|
Okay I've gone ahead and made some changes to the authentication layer. This allows it to be a little more flexible and extendable.
Cheers for the PR though. 😄 |
Closed
Closed
Closed
wayne5w
referenced
this pull request
Mar 17, 2016
Instead of using the existing Laravel router we will use a new instance. This should prevent the APIs internal dispatcher from overriding the current route on the actual Laravel router instance. There does not seem to be any need for the router instance that is injected into the adapter to be the actual Laravel router, as the adapter just needs an instance to dispatch the API-only routes.
Closed
wangyuanhui
referenced
this pull request
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to specify in the config which column to use as a 'username' when authenticating with the Basic Provider.
By default, it will still use the email column. Just wanted to add some more flexibility for a project I am working on.
If anything needs to be modified before merging, let me know and I will be happy to make any changes.
Brad