Skip to content

Conversation

@joaom00
Copy link
Contributor

@joaom00 joaom00 commented Apr 13, 2023

Allow consumers to override component's props. Some examples where it can be useful:

  • Provide a custom aria-label to Command.Loading
  • Although this is not the main use case of this lib, makes possible to override aria-expanded on Command.Input to build an accessible combobox where the list opens when the focus is on the input or after typing.

@vercel
Copy link

vercel bot commented Apr 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cmdk-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2023 11:31am

@joaom00 joaom00 changed the title chore: allow override props Allow override props Apr 13, 2023
@tonyfarney
Copy link

This modification would allow us to workaround accessibility issues the library has. For example: #179

Please merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants