Skip to content

fix: set dialog title and description when provided to avoid Radix-ui error #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −1
Open

fix: set dialog title and description when provided to avoid Radix-ui error #360

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8396785
fix: set dialog title when provided
tnyo43 May 17, 2025
126206e
fix: set dialog description when provided
tnyo43 Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cmdk/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ type DialogProps = RadixDialog.DialogProps &
contentClassName?: string
/** Provide a custom element the Dialog should portal into. */
container?: HTMLElement
/** Provide a hidden description text to the Dialog content */
description?: string
}
type ListProps = Children &
DivProps & {
Expand Down Expand Up @@ -880,12 +882,14 @@ const List = React.forwardRef<HTMLDivElement, ListProps>((props, forwardedRef) =
* Renders the command menu in a Radix Dialog.
*/
const Dialog = React.forwardRef<HTMLDivElement, DialogProps>((props, forwardedRef) => {
const { open, onOpenChange, overlayClassName, contentClassName, container, ...etc } = props
const { open, onOpenChange, overlayClassName, contentClassName, container, title, description, ...etc } = props
return (
<RadixDialog.Root open={open} onOpenChange={onOpenChange}>
<RadixDialog.Portal container={container}>
<RadixDialog.Overlay cmdk-overlay="" className={overlayClassName} />
<RadixDialog.Content aria-label={props.label} cmdk-dialog="" className={contentClassName}>
{title && <RadixDialog.Title hidden>{title}</RadixDialog.Title>}
Copy link
Author

@tnyo43 tnyo43 May 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RadixDialog.Title is set with hidden option, so its appearance doesn't change.

{description && <RadixDialog.Description hidden>{description}</RadixDialog.Description>}
<Command ref={forwardedRef} {...etc} />
</RadixDialog.Content>
</RadixDialog.Portal>
Expand Down