Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added interfaces instead hardcoding #42

Merged
merged 2 commits into from
Mar 5, 2023
Merged

Added interfaces instead hardcoding #42

merged 2 commits into from
Mar 5, 2023

Conversation

dipeshdulal
Copy link
Owner

New domains folder has been added for this.
All the interfaces are now defined in domains folder.

This should be able to close #10

dipeshhkc
dipeshhkc approved these changes Mar 5, 2023
View reviewed changes
Copy link
Collaborator

@dipeshhkc dipeshhkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. This will add lots of flexibility to the project. Thanks for adding this.

SujalKokh
SujalKokh approved these changes Mar 5, 2023
View reviewed changes
Copy link
Collaborator

@SujalKokh SujalKokh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 🥇

BinodKafle
BinodKafle approved these changes Mar 5, 2023
View reviewed changes
Copy link
Collaborator

@BinodKafle BinodKafle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BinodKafle BinodKafle merged commit 2a5bbb3 into master Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BinodKafle BinodKafle BinodKafle approved these changes

@SujalKokh SujalKokh SujalKokh approved these changes

@dipeshhkc dipeshhkc dipeshhkc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement interfaces instead of hard coded services.
4 participants
@dipeshdulal @dipeshhkc @SujalKokh @BinodKafle