Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1 frame delay by introducing new UiStage #67

Merged
merged 6 commits into from
Aug 31, 2022
Merged

Fix 1 frame delay by introducing new UiStage #67

merged 6 commits into from
Aug 31, 2022

Conversation

JunichiSugiura
Copy link
Member

@JunichiSugiura JunichiSugiura commented Aug 31, 2022 •
edited
Loading

close #46
close #56

New UiStage

pub enum UiStage {
    /// Place to register Ui event
    Action,
    /// Stage to query spawned component. Mainly for registering global state changes.
    Prepare,
    /// Apply state changes -> rerender
    Render,
}
  • fix toggle_all
  • replace VirtualDomCommand<GlobalState> with simply GlobalState

Demo

Screen.Recording.2022-08-31.at.19.43.07.mov

@vercel
Copy link

vercel bot commented Aug 31, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
bevy-dioxus ✅ Ready (Inspect) Visit Preview Aug 31, 2022 at 5:44PM (UTC)

@JunichiSugiura JunichiSugiura changed the title Fix 1 frame delay by introducing more UiStage Fix 1 frame delay by introducing new UiStage Aug 31, 2022
@JunichiSugiura JunichiSugiura merged commit 894c400 into main Aug 31, 2022
@JunichiSugiura JunichiSugiura deleted the fix/#46-frame-delay branch August 31, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use trace instead of debug for even loop related logs 1 frame delay on ui
1 participant
@JunichiSugiura