Skip to content

Commit

Permalink
[apache#1328] fix(trino-connector): Fix the failed 'drop catalog' tes…
Browse files Browse the repository at this point in the history
…t on Trino image gravitino-ci-trino:0.1.3. (apache#1329)

### What changes were proposed in this pull request?

Fix the failed 'drop catalog' test on Trino image
gravitino-ci-trino:0.1.3.
Trino image gravitino-ci-trino:0.1.2 use the
gravitino-trino-connector-0.3.0-SNAPSHOT.jar, it does not support drop
catalog, so the tester has made it compatible with this.
Trino image gravitino-ci-trino:0.1.3 use the
gravitino-trino-connector-0.4.0-SNAPSHOT.jar, it support drop catalog.
 the test did not pass. 

### Why are the changes needed?

Fix: apache#1328

### Does this PR introduce _any_ user-facing change?

NO

### How was this patch tested?

NO
  • Loading branch information
diqiu50 committed Jan 8, 2024
1 parent e2dd062 commit 1a62d23
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion integration-test/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ tasks.test {

// Gravitino CI Docker image
environment("GRAVITINO_CI_HIVE_DOCKER_IMAGE", "datastrato/gravitino-ci-hive:0.1.7")
environment("GRAVITINO_CI_TRINO_DOCKER_IMAGE", "datastrato/gravitino-ci-trino:0.1.2")
environment("GRAVITINO_CI_TRINO_DOCKER_IMAGE", "datastrato/gravitino-ci-trino:0.1.3")

val testMode = project.properties["testMode"] as? String ?: "embedded"
systemProperty("gravitino.log.path", buildDir.path + "/integration-test.log")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -858,7 +858,8 @@ void testIcebergCatalogCreatedByGravitino() throws InterruptedException {
final String sql1 =
String.format("drop schema \"%s.%s\".%s cascade", metalakeName, catalogName, schemaName);
// Will fail because the iceberg catalog does not support cascade drop
containerSuite.getTrinoContainer().executeUpdateSQL(sql1);
Assertions.assertThrows(
RuntimeException.class, () -> containerSuite.getTrinoContainer().executeUpdateSQL(sql1));

final String sql2 =
String.format("show schemas in \"%s.%s\" like '%s'", metalakeName, catalogName, schemaName);
Expand Down Expand Up @@ -1038,7 +1039,7 @@ void testDropCatalogAndCreateAgain() throws InterruptedException {
createdMetalake.dropCatalog(NameIdentifier.of(metalakeName, catalogName));
// We need to test we can't load this catalog any more by Trino.
success = checkTrinoHasRemoved(sql, 30);
Assertions.assertFalse(success, "Trino should not load the catalog any more: " + sql);
Assertions.assertTrue(success, "Trino should not load the catalog any more: " + sql);
}
}

Expand Down

0 comments on commit 1a62d23

Please sign in to comment.