-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial setup #1
Conversation
5cdb493
to
db97bdb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good setup overall!
I've put some general review throughout the GitHub Actions workflows, but the big thing that's missing here are our unit tests *.test.ts
. Especially since the logic is so easy right now, we absolutely need to make sure we've got those in place :)
Co-authored-by: Wryn (yage) Wagner <github@wryn.coffee>
Co-authored-by: Wryn (yage) Wagner <github@wryn.coffee>
Co-authored-by: Wryn (yage) Wagner <github@wryn.coffee>
Co-authored-by: Wryn (yage) Wagner <github@wryn.coffee>
Co-authored-by: Wryn (yage) Wagner <github@wryn.coffee>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good looking tests! 👍
I have a few more pedantic comments that I'll leave to your discretion, otherwise this looks good to me
Oh I suppose we should probably be passing our own checks before we go live as well. Does somebody with admin want to go put the standard rules on this for the repo / |
Co-authored-by: Wryn (yage) Wagner <github@wryn.coffee>
Yep, good point! I'll apply the rules. |
Simple GitHub action for closing issues certain days after they have been marked with a stale label.
This addresses directus/directus#22959. A separate action is required as the currently used one (https://github.com/actions/stale) does not fulfill our needs, see actions/stale#1135 (comment).
In contrast, this action simply uses the labeling date to determine when to close an issue.
The action will be usable as follows:
main
, updating the dist if there are any changespackage.json
file needs to be adjustedstale-issues-action/package.json
Line 17 in 07eb2e5