This repository has been archived by the owner on Aug 28, 2020. It is now read-only.
Typings (Second attempt, damn you CRLF) #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdistin
suggested changes
Sep 19, 2017
src/lib/structures/Finalizer.js
Outdated
| @@ -18,7 +18,7 @@ class Finalizer { | |||
| /** | |||
| * @param {KlasaClient} client The Klasa Client | |||
| * @param {string} dir The path to the core or user finalizer pieces folder | |||
| * @param {Array} file The path from the pieces folder to the finalizer file | |||
| * @param {string[]} file The path from the pieces folder to the finalizer file | |||
There was a problem hiding this comment.
should just be a string here.
There was a problem hiding this comment.
You're right, in the typings, I wrote
public file: string;But wrote the wrong type in the JSDocs (got confused with Command). Fixed 👍
kyranet
added
Bug: Fixed
bdistin
approved these changes
Sep 20, 2017
kyranet
added
Meta: BugFix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.