Skip to content
This repository has been archived by the owner on Aug 28, 2020. It is now read-only.

Fix for commands that return a virtual "never". #76

Merged
merged 2 commits into from
Oct 30, 2017
Merged

Conversation

kyranet
Copy link
Contributor

@kyranet kyranet commented Oct 29, 2017

Some commands, like the ones that return a prompt (being the returned value something that is given by the user, for example, RichDisplay) and Discord.js uncaches it over time, it results on the bot permanently writting.

This PR fixes the unlimited typing state that is a result of some commands returning a never.

@kyranet kyranet added Bug: Fixed Issues that report bugs and have been fixed. Type: Maintenance Issues and PRs related to the maintenance of a module. labels Oct 29, 2017
@kyranet kyranet requested a review from bdistin October 29, 2017 21:11
@bdistin bdistin merged commit b6df5b5 into master Oct 30, 2017
@bdistin bdistin deleted the typing-fix branch October 30, 2017 00:46
@kyranet kyranet added Meta: BugFix PRs that fix bugs or issues. and removed Bug: Fixed Issues that report bugs and have been fixed. labels Feb 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Meta: BugFix PRs that fix bugs or issues. Type: Maintenance Issues and PRs related to the maintenance of a module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants