Skip to content
This repository has been archived by the owner on Aug 28, 2020. It is now read-only.

Settings Options namespace #828

Merged
merged 6 commits into from
Oct 4, 2019
Merged

Settings Options namespace #828

merged 6 commits into from
Oct 4, 2019

Conversation

UnseenFaith
Copy link
Contributor

@UnseenFaith UnseenFaith commented Oct 1, 2019 •
edited
Loading

Description of the PR

Allow throwOnError to be applied globally and adds a namespace for all of settings current and future options that can be defaulted.

Semver Classification

  • This PR only includes documentation or non-code changes.
  • This PR fixes a bug and does not change the (intended) framework interface.
  • This PR adds methods or properties to the framework interface.
  • This PR removes or renames methods or properties in the framework interface.

@UnseenFaith UnseenFaith changed the title Throw on error option Settings Options namespace Oct 1, 2019
@UnseenFaith UnseenFaith added the Status: Needs Typings PRs that need typings label Oct 1, 2019
@kyranet kyranet added Meta: Feature Issues and PRs related to new features. Mod: SettingsGateway Issues and PRs related to SettingsGateway. SEM: Major PRs that contain breaking changes and should be released in the next major version. Status: Ready To Merge PRs that are ready to merge. and removed Status: Needs Typings PRs that need typings labels Oct 2, 2019
@kyranet kyranet mentioned this pull request Oct 2, 2019
Open
@kyranet kyranet merged commit 6808cf8 into dirigeants:settings Oct 4, 2019
@kyranet kyranet mentioned this pull request Oct 4, 2019
Closed
4 tasks
@PyroTechniac PyroTechniac mentioned this pull request Oct 6, 2019
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kyranet kyranet kyranet approved these changes

Assignees
No one assigned
Labels
Meta: Feature Issues and PRs related to new features. Mod: SettingsGateway Issues and PRs related to SettingsGateway. SEM: Major PRs that contain breaking changes and should be released in the next major version. Status: Ready To Merge PRs that are ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UnseenFaith @kyranet