This repository has been archived by the owner on Aug 28, 2020. It is now read-only.

fix: Remove deepClone on SettingsFolder#get #841

Merged

kyranet merged 1 commit into settings from settings-get-non-cloned

Oct 17, 2019

Contributor

kyranet commented Oct 17, 2019

Description of the PR

Reverts #814, it has caused more issues than it solves, we will think of a better solution later.

Changes Proposed in this Pull Request (List new items in CHANGELOG.MD)

Reverted deepClone in get

Semver Classification

This PR only includes documentation or non-code changes.
This PR fixes a bug and does not change the (intended) framework interface.
This PR adds methods or properties to the framework interface.
This PR removes or renames methods or properties in the framework interface.


          fix: Remove deepClone on SettingsFolder#get

9f5a897

kyranet added SEM: Major Meta: BugFix Priority: High Mod: SettingsGateway labels

kyranet requested a review from UnseenFaith

October 17, 2019 06:18

kyranet merged commit d8d3d9a into settings

kyranet deleted the settings-get-non-cloned branch

October 17, 2019 06:30

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Meta: BugFix Mod: SettingsGateway Priority: High SEM: Major