Skip to content
This repository has been archived by the owner on Aug 28, 2020. It is now read-only.

Fix RichMenu#run() return value type #91

Merged
merged 4 commits into from
Nov 21, 2017
Merged

Fix RichMenu#run() return value type #91

merged 4 commits into from
Nov 21, 2017

Commits on Nov 21, 2017

  1. Fix RichMenu#run() return value type 

    `RichMenu#run()` returns the same type as `RichDisplay#run()`, which is
a `Promise<ReactionHandler>`.
    @kenany
    kenany committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    c751b1e View commit details
    Browse the repository at this point in the history

  2. Swap _determineEmojis() signatures 

    From the code, it seems like `RichDisplay#_determineEmojis()` has the
four-argument signature, whereas `RichMenu#_determineEmojis()` has the
two-argument signature. The typings have them mixed up, so this patch
swaps the signatures to reflect the code.
    @kenany
    kenany committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    e858b88 View commit details
    Browse the repository at this point in the history

  3. Make _determineEmojis() a protected method 

    Because `RichMenu` uses its parent's (`RichDisplay`)
`_determineEmojis()` method, the method must be defined as protected.
    @kenany
    kenany committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    a61563f View commit details
    Browse the repository at this point in the history

  4. Update to latest discord.js typings

    @kenany
    kenany committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    f5beb2d View commit details
    Browse the repository at this point in the history