Fix Viewport Checker #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the issue "Viewport Checker is not working with latest version of Google Chrome" dirkgroenen#54 Completely ignoring the `userAgent` check, replacing it with a simple Math.max() call between html, body and window. This may not be a perfect fix, however it works fine on all browsers. Tests were made on Windows and Mac on Chrome, Safari, Firefox, Opera, and on Android and iOS.
|
Hi Plamen Kostadinov, |
|
Tnx for the fix. Working for a now. |
fly85
approved these changes
Sep 25, 2017
|
Thanks @pkostadinov-2create and sorry guys for not being as active as I should. I'm living an extremely busy life these days so there's not much time to maintain the project. I'll make sure to merge this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue "Viewport Checker is not working with latest version of Google Chrome" #54
Completely ignoring the
userAgentcheck, replacing it with a simple Math.max() call between html, body and window.This may not be a perfect fix, however it works fine on all browsers. Tests were made on Windows and Mac on Chrome, Safari, Firefox, Opera, and on Android and iOS.