Add support for statements cache #10
Merged
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using sqlalchemy-turbodbc with SQL Alchemy 1.4.x will yield the below warning:
sqlalchemy.exc.SAWarning: Dialect mssql:turbodbc will not make use of SQL
compilation caching as it does not set the 'supports_statement_cache'
attribute to
True
. This can have significant performance implicationsincluding some performance degradations in comparison to prior SQLAlchemy
versions. Dialect maintainers should seek to set this attribute to True
after appropriate development and testing for SQLAlchemy 1.4 caching
support. Alternatively, this attribute may be set to False which will
disable this warning.
I've had a look over this link and based on that and a review of the code I don't see any reason given that
MSDialect_turbodbc
extendsMSDialect
(and there's not too much heavy lifting going on in it) that it can't also be enabled there.I did some basic testing of some use cases (ORM queries, some auto-mapping) and saw both that the warning message went away and there weren't any other errors that were created as a result of this change.