Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strings are no longer candidates for execution in sqlalchemy 2.x #14

Merged
merged 3 commits into from
Feb 13, 2023

Conversation

adamchen
Copy link
Collaborator

@adamchen adamchen commented Feb 2, 2023

I noticed this morning that when we try and get the server version as part of opening a new connection it fails. This is because since 2.x, raw Python strings are no longer eligible for execution - they need to be wrapped in text() or similar.

I've verified this works in 2.x and also checked that it was backward-compatible with 1.4.x.

@dirkjonker
Copy link
Owner

@adamchen thanks

@dirkjonker dirkjonker merged commit 643069e into dirkjonker:master Feb 13, 2023
@dirkjonker
Copy link
Owner

@adamchen would you like to become maintainer or owner for this repository? I have not used Python/Turbodbc for years and am unlikely to use it in the future.

@dirkjonker
Copy link
Owner

Released as v1.2.0
https://pypi.org/project/sqlalchemy-turbodbc/1.2.0/

@adamchen
Copy link
Collaborator Author

Thanks @dirkjonker! I turned things down the first time as I wasn't really expecting to have to tweak stuff much, but I think at this point it may be sensible to be at least one of those things - possibly owner if you don't expect to work with it much in future?

@dirkjonker
Copy link
Owner

@adamchen I have sent you an invite, let me know your pypi.org username, then I will add you as a maintainer there as well!

@adamchen
Copy link
Collaborator Author

Thanks for sending that over - I've accepted! I'm also adamchen over at PyPi, will keep an eye out there as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants