Skip to content
This repository has been archived by the owner on Feb 18, 2025. It is now read-only.

CI: Pin a minimum supported stable Rust version #32

Closed
b-r-u opened this issue Jun 3, 2018 · 6 comments · Fixed by #34
Closed

CI: Pin a minimum supported stable Rust version #32

b-r-u opened this issue Jun 3, 2018 · 6 comments · Fixed by #34

Comments

@b-r-u
Copy link
Contributor

b-r-u commented Jun 3, 2018

To avoid accidentally increasing the minimum supported Rust version, the CI scripts could include a build for a fixed stable Rust version.
I'm not sure what the minimum working version is right now (I tried to lower it with #31), because I couldn't test all platforms.

@b-r-u
Copy link
Contributor Author

b-r-u commented Jun 4, 2018

Ok, so I tested different Rust versions on a fork (https://github.com/b-r-u/directories-rs/commits/ci-rust-1.20) and it looks like everything works even with 1.13 (from 2016-11-10, which stabilized the ? operator) with a minor change (b-r-u@7466791).

I also conducted a small survey on the minimum supported Rust version of some popular crates:

Crate Minimum Rust Version
serde 1.13
log 1.16
lazy_static 1.21
regex 1.20

https://github.com/rust-lang/regex#minimum-rust-version-policy

@soc
Copy link
Collaborator

soc commented Jun 4, 2018

Thanks @b-r-u, I'll look into this tomorrow!

@soc
Copy link
Collaborator

soc commented Jun 21, 2018

@b-r-u Sorry for the delay ... so what I'm wondering is whether there is some way to explicitly set minimal versions for Rust and crates in a separate CI run.

Apart from that, would you suggest lowering the crate versions mentioned in cargo.toml to the minimum you figured out here?

@b-r-u
Copy link
Contributor Author

b-r-u commented Jun 21, 2018

so what I'm wondering is whether there is some way to explicitly set minimal versions for Rust and crates in a separate CI run.

There is rust-lang/cargo#4100 for minimal crate versions but I think it's not yet stable.

Apart from that, would you suggest lowering the crate versions mentioned in cargo.toml to the minimum you figured out here?

Maybe there was a misunderstanding? I was looking at popular crates to get a feeling for the minimal Rust version they support. I don't think you should lower any dependency versions.

@soc
Copy link
Collaborator

soc commented Jun 21, 2018

Ah, alright, understood. Thanks!

@b-r-u
Copy link
Contributor Author

b-r-u commented Jun 21, 2018

I could have been clearer and updated the comment! #32 (comment)

b-r-u added a commit to b-r-u/directories-rs that referenced this issue Jun 22, 2018
This adds an additional build for a fixed Rust version to avoid
accidentally depending on a newer version.

Fixes dirs-dev#32
b-r-u added a commit to b-r-u/directories-rs that referenced this issue Jun 22, 2018
This adds an additional build for a fixed Rust version to avoid
accidentally depending on a newer version.

Fixes dirs-dev#32
b-r-u added a commit to b-r-u/directories-rs that referenced this issue Jun 22, 2018
This adds an additional build for a fixed Rust version to avoid
accidentally depending on a newer version.

Fixes dirs-dev#32
@soc soc closed this as completed in #34 Jun 22, 2018
soc pushed a commit that referenced this issue Jun 22, 2018
This adds an additional build for a fixed Rust version to avoid
accidentally depending on a newer version.

Fixes #32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants