Adding Support for PWM Absolute Mag Encoders #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ics/2023-Absolute-Encoder-Swerve into forked-updates-testing
This reverts commit e3dd816.
This reverts commit ef5f070.
I'm having an error getting the leds to change color based off button input. It will change once after deploying, but not after that.
NOTE: The wrist is offset by 20 degrees. We could fix it, but then we would need to change all other positions by 20 degrees as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
This PR adds support for PWM Absolute Mag Encoders to the Team364 BaseFalconSwerve library. Our team, FRC 1714, used this modified code in the 2023 season successfully and this is my suggestion for how to include support for PWM Absolute Mag Encoders like the Thrifty Absolute Mag Encoder. Feel free to suggest different ways to do it.