fix(tracking): set event value to 0 since it's summed by Matomo

dis-moi · Nov 22, 2019 · 30a9a5e · 30a9a5e
1 parent dfae648
commit 30a9a5e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/src/app/background/sagas/tracking/trackContributor.saga.ts b/src/app/background/sagas/tracking/trackContributor.saga.ts
@@ -6,10 +6,7 @@ import {
   createErrorAction,
   getURLFromActionMeta
 } from 'app/actions';
-import {
-  getContributorId,
-  getContributorName
-} from 'app/background/reducers/subscriptions.reducer';
+import { getContributorName } from 'app/background/reducers/subscriptions.reducer';
 
 export const trackContributorActionSaga = (tracker: Tracker) =>
   function*(action: ContributorAction): SagaIterator {
@@ -18,7 +15,7 @@ export const trackContributorActionSaga = (tracker: Tracker) =>
         category: 'Contributor',
         action: action.type.toLowerCase(),
         name: getContributorName(action),
-        value: getContributorId(action) as number,
+        value: 0,
         url: getURLFromActionMeta(action)
       });
     } catch (e) {

diff --git a/src/app/background/sagas/tracking/trackUI.saga.ts b/src/app/background/sagas/tracking/trackUI.saga.ts
@@ -31,7 +31,7 @@ export const trackInstallSaga = (tracker: Tracker) =>
         category: 'Extension',
         action: action.payload.installationDetails.reason,
         name: action.payload.installationDetails.version,
-        value: 0x5e7
+        value: 0
       });
     } catch (e) {
       createErrorAction()(e);
@@ -57,7 +57,7 @@ export const trackCloseSaga = (tracker: Tracker) =>
         category: 'UI',
         action: 'close',
         name: action.payload.cause.toString(),
-        value: 0xc105e,
+        value: 0,
         url: getURLFromActionMeta(action)
       });
     } catch (e) {
@@ -72,7 +72,7 @@ export const trackBrowserActionClickedSaga = (tracker: Tracker) =>
         category: 'UI',
         action: 'click',
         name: 'BrowserAction',
-        value: 0xac710c11c
+        value: 0
       });
     } catch (e) {
       createErrorAction()(e);