chore(specs): fix tests that are mocking the entire background state

dis-moi · Nov 7, 2019 · fc9cc1c · fc9cc1c
1 parent 30fcc8a
commit fc9cc1c
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 24 deletions.
diff --git a/src/app/background/reducers/bullesUpdate.reducer.ts b/src/app/background/reducers/bullesUpdate.reducer.ts
@@ -4,6 +4,10 @@ export interface BullesUpdateState {
   lastUpdateMessageShowDate: null | Date;
 }
 
+export interface BullesUpdateStateSlice {
+  bullesUpdate: BullesUpdateState;
+}
+
 const initialState: BullesUpdateState = {
   lastUpdateMessageShowDate: null
 };

diff --git a/src/app/background/selectors/bullesUpdate.selectors.spec.ts b/src/app/background/selectors/bullesUpdate.selectors.spec.ts
@@ -1,30 +1,12 @@
-import { BackgroundState } from '../reducers';
 import { expect } from 'chai';
 import { getUpdateMessageLastShowDate } from './bullesUpdate.selectors';
+import { BullesUpdateStateSlice } from '../reducers/bullesUpdate.reducer';
 
 describe('background > selectors > bullesUpdate', () => {
   describe('getUpdateMessageLastShowDate', () => {
     it("returns the message's last date", () => {
       const someDay = new Date('2019-09-13');
-      const state: BackgroundState = {
-        tabs: {},
-        installationDetails: {
-          version: '',
-          reason: 'INSTALL'
-        },
-        prefs: {
-          likedNotices: [],
-          dislikedNotices: [],
-          dismissedNotices: [],
-          readNotices: [],
-          tosAccepted: true
-        },
-        resources: {
-          matchingContexts: [],
-          drafts: [],
-          contributors: []
-        },
-        subscriptions: [],
+      const state: BullesUpdateStateSlice = {
         bullesUpdate: { lastUpdateMessageShowDate: someDay }
       };
       expect(getUpdateMessageLastShowDate(state)).to.eql(someDay);

diff --git a/src/app/background/selectors/bullesUpdate.selectors.ts b/src/app/background/selectors/bullesUpdate.selectors.ts
@@ -1,10 +1,13 @@
 import { createSelector } from 'reselect';
 import * as R from 'ramda';
-import { BackgroundState } from '../reducers';
-import { BullesUpdateState } from '../reducers/bullesUpdate.reducer';
+import {
+  BullesUpdateState,
+  BullesUpdateStateSlice
+} from '../reducers/bullesUpdate.reducer';
 
-const getBullesUpdateState = (state: BackgroundState): BullesUpdateState =>
-  state.bullesUpdate;
+const getBullesUpdateState = (
+  state: BullesUpdateStateSlice
+): BullesUpdateState => state.bullesUpdate;
 
 export const getUpdateMessageLastShowDate = createSelector(
   [getBullesUpdateState],

diff --git a/src/app/background/selectors/subscriptions.selectors.spec.ts b/src/app/background/selectors/subscriptions.selectors.spec.ts
@@ -35,6 +35,7 @@ describe('background > selectors > subscriptions ', () => {
         },
         resources: {
           matchingContexts: [],
+          restrictedContexts: [],
           drafts: [],
           contributors: [
             contributor1,