Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Profile page] Avatar is distorted #766

Closed
newick opened this issue Jan 21, 2021 · 6 comments · Fixed by #775
Closed

[Profile page] Avatar is distorted #766

newick opened this issue Jan 21, 2021 · 6 comments · Fixed by #775
Assignees
Labels

Comments

@newick
Copy link
Member

newick commented Jan 21, 2021

It comes from the WP styles.
A solution can be to reset max-width.

But I thought I already corrected it. It was not pushed to prod ? @lutangar @JalilArfaoui

@newick newick added the design label Jan 21, 2021
@newick newick self-assigned this Jan 21, 2021
@newick newick linked a pull request Feb 4, 2021 that will close this issue
bmenant added a commit that referenced this issue Feb 4, 2021
## [3.61.1](v3.61.0...v3.61.1) (2021-02-04)

### Bug Fixes

* **Avatar:** forces to reset WP max-width [#766](#766) ([0108534](0108534))
@MaartenLMEM
Copy link
Contributor

Hi @christpet, I do not understand why it s in this column prod chrome.
On mobile, I still see a distorted avatar on mobile, for example here : https://www.dismoi.io/eclaireurs/16/Le-Meme-en-Mieux

@MaartenLMEM
Copy link
Contributor

@newick je vois que tu avais une nouvelle correction et qu'elle a été merged en version 3.67.2

Le 14 avril CaptainFact m'a remonté à nouveau le problème sur mobile (donc en prod)
Je viens de jeter un oeil :

  • profils-staging en format mobile, l'avatar est toujours rattatiné sur mobile (voir capture plus bas)
  • en prod sur Version 3.61.0 sur me destkop si je réduit la fenêtre en taille mobile - idem
  • sur mobile sans aucune extension tous les avatars des pages profils sont ratatinés, par exemple https://www.dismoi.io/eclaireurs/60/Amazon-Antidote

Quelques hypothèses :

  • un rollback quelquepart ? Comme le problème est partout j'ai du mal à croire en cette hypothèse
  • la solution n'a pas résolu le problème et cela a échappé à la recette ? Possible mais peu probable.

image

@newick
Copy link
Member Author

newick commented May 5, 2021

@MaartenLMEM I don't get it.
In the master branch I see the code

          & > img {
            max-width: initial;
            width: 70px;
            height: auto;
          }

the same part in the code is
image

So the height doesn't in the prod code.

@gregoirelacoste could you look upon that ?

@gregoirelacoste
Copy link
Member

gregoirelacoste commented May 5, 2021

@newick you right, in staging it's working well. So it will be fixed in the next released.

staging:
image

@gregoirelacoste
Copy link
Member

* profils-staging en format mobile, l'avatar est toujours rattatiné sur mobile (voir capture plus bas)

your screen show prod version

@MaartenLMEM
Copy link
Contributor

Ok sorry guys I made a mistake it s ok !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants