Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Badge stays with a number saying "there are N notices" but there are not #916

Closed
MaartenLMEM opened this issue Apr 25, 2021 · 1 comment · Fixed by #925
Closed

Badge stays with a number saying "there are N notices" but there are not #916

MaartenLMEM opened this issue Apr 25, 2021 · 1 comment · Fixed by #925
Assignees
@lutangar
Labels
bug 🐞 released

Comments

@MaartenLMEM
Copy link
Contributor

Describe the bug
After changing page on website lequipe.fr et youtube.fr, badge stays with a number saying "there are N notices" but there are no more notices
This biug does not happen on other website like opodo.fr for example.

See example on lequipe.fr in this Vidéo

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://www.lequipe.fr/Football/Article/Les-notes-de-france-bolivie-lemar-marque-des-points/1025532
  2. Wait notice 277 appear
  3. click on any link to go to another page if same website lequipe.fr
    5 : see bug

Expected behavior
Badge change state.

Desktop (please complete the following information):

  • OS: windows
  • Browser : chrome
  • Version [e.g. 22]

Extension

  • Version Dismoi 3.61.0 (prod), also on version chrome proding 3.57.1
  • Installed from store
@lutangar lutangar self-assigned this Apr 27, 2021
lutangar added a commit that referenced this issue Apr 27, 2021
@lutangar
fix(badge): Badge reset on context not triggered
c71dd8d 
On some events we call update badge with 0 notices number and this was ignored.
Fix #916
This was referenced Apr 27, 2021
Merged
Open
lutangar added a commit that referenced this issue Apr 28, 2021
@lutangar
fix(badge): Badge reset on context not triggered
eebf40a 
On some events we call update badge with 0 notices number and this was ignored.
Fix #916
bmenant added a commit that referenced this issue Apr 28, 2021
@bmenant
chore: release 3.71.3
ef976e2 
## [3.71.3](v3.71.2...v3.71.3) (2021-04-28)

### Bug Fixes

* **badge:** Badge reset on context not triggered ([eebf40a](eebf40a)), closes [#916](#916)
@bmenant
Copy link
Member

bmenant commented Apr 28, 2021

🎉 This issue has been resolved in version 3.71.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

newick pushed a commit that referenced this issue May 28, 2021
@lutangar @newick
fix(badge): Badge reset on context not triggered
bab1bd2 
On some events we call update badge with 0 notices number and this was ignored.
Fix #916
newick pushed a commit that referenced this issue May 28, 2021
@bmenant @newick
chore: release 3.71.3
867b8fe 
## [3.71.3](v3.71.2...v3.71.3) (2021-04-28)

### Bug Fixes

* **badge:** Badge reset on context not triggered ([eebf40a](eebf40a)), closes [#916](#916)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lutangar lutangar

Labels
bug 🐞 released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(badge): Badge reset on context not triggered dis-moi/extension
3 participants
@lutangar @bmenant @MaartenLMEM