Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Safe Area View to make sure of editor usability on new iphones #321

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

sallesma
Copy link
Member

@sallesma sallesma commented Feb 3, 2021

Before sending your pull-request 💌 make sure :

  • The tests are up-to-date and your code is tested

@arribbar could you test if the layout is better in the editor? I have no way to try it myself...

Otherwise we could use something like this to add bottom spacing...

    ...Platform.select({
      ios: {
        padding: 5,
        alignItems: 'flex-start',
        minHeight: 60,
      },
      default: {
        alignItems: 'center',
        minHeight: 40,
      },
    }),

Resolves #318

Copy link
Member Author

@sallesma sallesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il y a quand même pas mal d'effets de bord sur les autres devices.

C'est surtout celui sur la MinimalPage qui me fait peur, les autres me paraissent plutôt facile à traiter avec des margins/paddings

Edit : j'ai ajouté un commit pour essayer de résoudre ça, je te laisse vérifier que ça marche bien sur ton iphone...

src/styles/filters.style.js Show resolved Hide resolved
src/Components/DrillPageMinimal.js Show resolved Hide resolved
src/Components/TrainingPage.js Show resolved Hide resolved
src/Components/VideoPage.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor bottom unusable on ios
2 participants