Fix VimeoVideo.js with updated Vimeo API #411
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Vimeo API call and subsequent processing of the response to get the video link.
|
attempt to fix #407 |
|
Ok, at least I managed to run the tests and they all pass. Now, I just need to check if the fix actually work...sorry that's not really the proper way to do all this ! |
|
Ok, I finally managed to make Expo Go work and start digging into the problem. Edit: confirmed by https://stackoverflow.com/a/74120966 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick and dirty attempt to implement the changes I could figured out from the revamped Vimeo API documentation (ref: https://developer.vimeo.com/api/files/video-links)
I am complete noob in mobile dev so I would need to spare some time to setup and understand the dev environment required to properly test and validate this change. So I just thought, it might be quicker to just push this PR, initiate the discussion, and maybe you will be able to check it much quicker than myself.
Before sending your pull-request 💌 make sure :