Implement inline replies feature #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HydroPage
reviewed
Oct 3, 2020
src/main/java/net/dv8tion/jda/internal/requests/restaction/MessageActionImpl.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
MinnDevelopment
commented
Nov 15, 2020
| * <br>This is identical to {@code message.getChannel().sendFile(data, name, options).reference(message)}. | ||
| * You can use {@link MessageAction#mentionRepliedUser(boolean) mentionRepliedUser(false)} to not mention the author of the message. | ||
| * | ||
| * <p>For further info, see {@link MessageChannel#sendFile(File, net.dv8tion.jda.api.utils.AttachmentOption...)} and {@link MessageAction#reference(Message)}. |
There was a problem hiding this comment.
Fix this link (and others)
Not every mention is included in the content so this is necessary Inline replies use mentions which are not in the content, this would fail only when the guild is loaded (due to our handling)
This comment has been minimized.
This comment has been minimized.
GoldRenard
reviewed
Nov 21, 2020
| { | ||
| obj.put("allowed_mentions", getAllowedMentionsObj()); | ||
| obj.put("message_reference", DataObject.empty() |
There was a problem hiding this comment.
Just tested this. Not sure is that an issue or not, but replying is not working in case of just sending a file without any other message content.
In this case rest action ignores this payload_json as it thinks it's empty so message_reference never sent to the Discord with a file.
There was a problem hiding this comment.
This has been fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
discord/discord-api-docs#2118