Message interface declutter & mention / component abstraction #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DV8FromTheWorld would be good if you could comment on the task items. |
| import org.jetbrains.annotations.NotNull; | ||
| import org.jetbrains.annotations.Nullable; | ||
|
|
||
| public class MessageComponents |
There was a problem hiding this comment.
Lets group the getters in this file by the types. (Buttons with buttons, Menus with menus)
6 tasks
MinnDevelopment
added
the
status: documentation needed
|
This will also need to address mentions in slash command interactions. Options of type STRING can contain mentions, which are resolved by discord. |
Sanduhr32
reviewed
Jan 7, 2022
| this.jda = jda; | ||
| this.guild = guild; | ||
|
|
||
| this.users = Collections.unmodifiableList(processMentions(Message.MentionType.USER, new ArrayList<>(), true, this::matchUser)); |
There was a problem hiding this comment.
You wrap a lot of collections returned by processMentions() with a Collections.unmodifiableList() call.
Maybe change the methods returned collection.
Suggested change
| this.users = Collections.unmodifiableList(processMentions(Message.MentionType.USER, new ArrayList<>(), true, this::matchUser)); | |
| this.users = processMentions(Message.MentionType.USER, new ArrayList<>(), true, this::matchUser); |
| } | ||
| catch (NumberFormatException ignored) {} | ||
| } | ||
| return collection; |
There was a problem hiding this comment.
Suggested change
| return collection; | |
| return Collections.unmodifiableList(collection); |
Comment on lines
+67
to
+70
| this.roles = Collections.unmodifiableList(processMentions(Message.MentionType.ROLE, new ArrayList<>(), true, this::matchRole)); | ||
| this.textChannels = Collections.unmodifiableList(processMentions(Message.MentionType.CHANNEL, new ArrayList<>(), true, it -> matchChannel(it, ChannelType.TEXT, TextChannel.class))); | ||
| this.voiceChannels = Collections.unmodifiableList(processMentions(Message.MentionType.CHANNEL, new ArrayList<>(), true, it -> matchChannel(it, ChannelType.VOICE, VoiceChannel.class))); | ||
| this.emotes = Collections.unmodifiableList(processMentions(Message.MentionType.EMOTE, new ArrayList<>(), true, this::matchEmote)); |
There was a problem hiding this comment.
Suggested change
| this.roles = Collections.unmodifiableList(processMentions(Message.MentionType.ROLE, new ArrayList<>(), true, this::matchRole)); | |
| this.textChannels = Collections.unmodifiableList(processMentions(Message.MentionType.CHANNEL, new ArrayList<>(), true, it -> matchChannel(it, ChannelType.TEXT, TextChannel.class))); | |
| this.voiceChannels = Collections.unmodifiableList(processMentions(Message.MentionType.CHANNEL, new ArrayList<>(), true, it -> matchChannel(it, ChannelType.VOICE, VoiceChannel.class))); | |
| this.emotes = Collections.unmodifiableList(processMentions(Message.MentionType.EMOTE, new ArrayList<>(), true, this::matchEmote)); | |
| this.roles = processMentions(Message.MentionType.ROLE, new ArrayList<>(), true, this::matchRole); | |
| this.textChannels = processMentions(Message.MentionType.CHANNEL, new ArrayList<>(), true, it -> matchChannel(it, ChannelType.TEXT, TextChannel.class)); | |
| this.voiceChannels = processMentions(Message.MentionType.CHANNEL, new ArrayList<>(), true, it -> matchChannel(it, ChannelType.VOICE, VoiceChannel.class)); | |
| this.emotes = processMentions(Message.MentionType.EMOTE, new ArrayList<>(), true, this::matchEmote); |
|
|
||
| if (guild == null) | ||
| { | ||
| this.members = new ArrayList<>(); |
There was a problem hiding this comment.
Let's also wrap this.
Suggested change
| this.members = new ArrayList<>(); | |
| this.members = Collections.unmodifiableList(new ArrayList<>()); |
Should options of types user, channel, role & mentionable also be included in their respective lists? |
MinnDevelopment
modified the milestones:
5.0.0-alpha.5 (Interactions & Messages),
5.0.0-alpha.6
6 tasks
|
Superseded by #2015 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
This PR implements the new message mentions / components abstractions that are planned for v5. It will be draft until the checklist is complete. This is open for contribution.
TODO