Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Interaction#getUserLocale and Interaction#getGuildLocale #1983

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Add Interaction#getUserLocale and Interaction#getGuildLocale #1983

merged 1 commit into from
Jan 12, 2022

Conversation

sebm253
Copy link

@sebm253 sebm253 commented Jan 12, 2022

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

this PR adds Interaction#getUserLocale and Interaction#getGuildLocale. see discord/discord-api-docs#4265. I'm not too sure about the behavior of getGuildLocale because there's a separate field for the preferred guild locale (however that is still only changeable with the COMMUNITY feature, effectively being Guild#getLocale), so feel free to comment on that. this is a fix for my previous PR that I fucked up by rebasing.

@MinnDevelopment MinnDevelopment merged commit f08f75a into discord-jda:rework/interactions Jan 12, 2022
@sebm253 sebm253 deleted the feature/locale-interactions branch January 12, 2022 16:09
@MinnDevelopment MinnDevelopment mentioned this pull request Jan 12, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants