Add support for Application Emoji #2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
yoyosource
changed the title
Andre601
reviewed
Sep 4, 2024
Andre601
suggested changes
Sep 4, 2024
|
I tested this code in production for around 2 weeks now. It works fine for me. |
src/main/java/net/dv8tion/jda/api/entities/emoji/ApplicationEmoji.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/EntityBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/emoji/ApplicationEmojiImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/emoji/ApplicationEmojiImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/emoji/ApplicationEmojiImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/EntityBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/emoji/ApplicationEmojiImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/managers/ApplicationEmojiManagerImpl.java
Outdated
Show resolved
Hide resolved
yoyosource
force-pushed
the
feature/application-emojis
branch
from
eecd1c0
to
4521244
Compare
|
I actually dont know why the online (github.dev) editor creates such big diffs. I am trying to fix those. |
You are likely changing line endings, when you use git directly it will make sure to convert them to the correct line endings when committing files. |
yoyosource
force-pushed
the
feature/application-emojis
branch
from
4521244
to
9d48ce5
Compare
It is fixed now. I never changed it intentionally. |
src/main/java/net/dv8tion/jda/api/entities/emoji/CustomEmoji.java
Outdated
Show resolved
Hide resolved
MinnDevelopment
approved these changes
Nov 3, 2024
MinnDevelopment
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
Supersedes #2712 with a cleaned up commit list and implementation of freya022's change requests.
Implements this api-docs PR: discord/discord-api-docs#7010.