Skip to content

Conversation

@Shivansh-007
Copy link
Member

Please approve, kthx

@onerandomusername onerandomusername added a: dependencies Related to package dependencies and management a: tools Development related to our toolchain (Docker, poetry, flake8) skip changelog Skip the need for a changelog entry for a Pull Request labels Nov 27, 2021
@Shivansh-007 Shivansh-007 enabled auto-merge (squash) November 27, 2021 06:56
Copy link
Contributor

@onerandomusername onerandomusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

The reason to alphabetize is because taskipy will show them in the order they're defined here....

@Shivansh-007 Shivansh-007 merged commit 7347f59 into main Nov 27, 2021
@Shivansh-007 Shivansh-007 deleted the add-task-to-poetry-lock-without-updating-the-deps-also-do-task-export-including-the-doc-deps branch November 27, 2021 07:00
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 1509962280

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.756%

Totals Coverage Status
Change from base Build 1509916199: 0.0%
Covered Lines: 1672
Relevant Lines: 2123

💛 - Coveralls

@onerandomusername
Copy link
Contributor

A little slow there, coveralls.

Shivansh-007 added a commit that referenced this pull request Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: dependencies Related to package dependencies and management a: tools Development related to our toolchain (Docker, poetry, flake8) skip changelog Skip the need for a changelog entry for a Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants