Feature: Database #65
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also cleans up redundant imports in `config.py` and fixes some type hints.
This function is ran before the discord modmail bot is ran so that the bot is not ran unnecessarily even if the DB is not responding. It creates a local session which can be used throughout the bot and then tests if the db is responding. If the DB is not responding it would log the error with the exception and then exit, it doesn't raise the exception as the the sqlalchemy connection errors are usually really long and maybe "spammy", to reduce the logs down it just logs down the error and then exists silently.
Since we are getting the embed json content directly via discord.py's embed and not generating or touching it, we are safe and validation shouldn't be needed. I have made an extra commit here, in case we ever need it again in future we won't need to rewrite it all over again.
Because it stores things not in the messages/tickets, and it's just use to refer to the message the thread starts from in the ticket logging channel. https://discord.com/channels/798235512208490526/845824657306288158/881136355348992060
Assert statements are removed when running in optimized mode, but we don't.
Shivansh-007
added
a: database
Shivansh-007
force-pushed
the
feat/db-client
branch
from
1689e39 to
945af5d
Compare
Contributor
|
Removed Shivansh as he's busy, @bast0006 is hopefully going to finish this pr. |
Codecov Report
@@ Coverage Diff @@
## main #65 +/- ##
==========================================
- Coverage 38.62% 32.92% -5.70%
==========================================
Files 16 27 +11
Lines 769 902 +133
Branches 105 110 +5
==========================================
Hits 297 297
- Misses 459 590 +131
- Partials 13 15 +2
Continue to review full report at Codecov.
|
Shivansh-007
added
s: needs review
Member
Author
|
Closing this, as I would be rewriting it using tortoise ORM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #55
This PR adds an async PostgreSQL setup with the help of SQLAlchemy and alembic. Alembic
is a tool for keeping track of the database migration history and SQLAlchemy(with asyncpg) is a popular ORM tool. The following models have been added to the DB:
Where the
EmbedsandAttachmentsare foreign keys to theMessages.idcolumn.TODO
Docker support(deffered)