News channel message publish #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SubZero0
reviewed
May 13, 2020
src/Discord.Net.WebSocket/Entities/Messages/SocketUserMessage.cs
Outdated
Show resolved
Hide resolved
|
Great feedback, @SubZero0. Working on resolving them now. |
2. Clarified xml docs 3. Properly threw exceptions instead of failing silently.
Still34
requested changes
May 14, 2020
MattTheDev
commented
May 18, 2020
foxbot
approved these changes
May 20, 2020
anonymousheadless
pushed a commit
to anonymousheadless/Discord.Net
that referenced
this pull request
Mar 29, 2021
* Added PublishAsync to Messages. * Added missing implementation. * 1. Aligned with naming standards 2. Clarified xml docs 3. Properly threw exceptions instead of failing silently. * Additional documentation included. * Removed un-needed comments. Co-authored-by: Matt Smith <v-matsm@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds in the ability to Publish a new message within a news chnanel. If the channel type is not a news channel, it'll ignore the request to publish. I thought about returning an error here, and this could easily be added.
Resolves #1528
Changes
Addition of the API handler for /crosspost endpoint.
Addition of PublishAsync to the Socket and Rest Messages.
Only executes if the channels are news channel types.